🎨 Refactor CoreNode Renderability Logic 🚀 #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Node and Stage This avoids sending a free event each time we load a texture and; Improves the renderability changes and loading of texture w.r.t. texture state.
erikhaandrikman
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s New? ✨
This PR refactors Texture Throttling in the following ways:
How to Test? 🧪
RTT Changes: Use
test=rtt-dimension. 🖼️ You should see race conditions occurring prior to this PR.Texture Freed Fix: Add a rocko.png to the
test=texture-cleanup-criticaltest and move it in and out of the screen to validate. 🎯 (Not the prettiest, but it works!). Might create an automated test for this in the future.What’s Next? 🚀
More Testing! 🛠️