Skip to content

fix: safari 9 HTMLImageElement check #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 16, 2024
Merged

fix: safari 9 HTMLImageElement check #473

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3b54f9f
fix: safari 9 HTMLImageElement check
pecoram Dec 12, 2024
fe25630
fix: parentheses
pecoram Dec 12, 2024
92370a4
fix: typo
pecoram Dec 12, 2024
04771d9
fix: added HTMLImageElement existence check
pecoram Dec 12, 2024
83f8c91
refactor: added tdata variable
pecoram Dec 12, 2024
5c0d6c2
fix: safari9 canvas IndexSizeError
pecoram Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/core/renderers/webgl/internal/RendererUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,10 @@ export function createIndexBuffer(glw: WebGlContextWrapper, size: number) {
export function isHTMLImageElement(obj: unknown): obj is HTMLImageElement {
return (
obj !== null &&
typeof obj === 'object' &&
obj.constructor &&
obj.constructor.name === 'HTMLImageElement'
((typeof obj === 'object' &&
obj.constructor &&
obj.constructor.name === 'HTMLImageElement') ||
obj instanceof HTMLImageElement)
Copy link
Contributor

@elsassph elsassph Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be safe/better to do the instanceof check first?

);
}

Expand Down
Loading