fix: Origin error when using Image() constructor #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the error: net::ERR_BLOCKED_BY_RESPONSE.NotSameOriginAfterDefaultedToSameOriginByCoep 302 (Found)
elsassph
reviewed
Dec 10, 2024
src/core/textures/ImageTexture.ts
Outdated
|
|
||
| async loadImageFallback(src: string, hasAlpha: boolean) { | ||
| const img = new Image(); | ||
| img.crossOrigin = 'anonymous'; |
Contributor
There was a problem hiding this comment.
I think Lightning 2 do it as well, but has some custom logic do NOT do it for Playstation.
Maybe don't autodetect the platform, but ImageTexture could have a static flag which could be externally disabled to not do set this crossOrigin.
Contributor
Author
There was a problem hiding this comment.
Funny enough that is only on SVG:
https://github.com/rdkcentral/Lightning/blob/fa1f699e8b00f087923875e72990bafc73893237/src/tools/Tools.mjs#L179
Contributor
Author
There was a problem hiding this comment.
PS4 is currently set to go the ION route if all goes well - so skipping this until it pops up as an issue again.
pecoram
suggested changes
Dec 11, 2024
Co-authored-by: Mirko Pecora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the error:
net::ERR_BLOCKED_BY_RESPONSE.NotSameOriginAfterDefaultedToSameOriginByCoep 302 (Found)