Skip to content

Conversation

@chiefcll
Copy link
Contributor

@chiefcll chiefcll commented Dec 2, 2024

Data attr missing in list for Proxy so any changes to data was not reflected in inspector output.

@chiefcll chiefcll changed the title fix: data attr in inspector not reactive fix: data attr in inspector not reactive.. Dec 3, 2024
@wouterlucas
Copy link
Contributor

Build is iffy because of race conditions with createImageBitmap on the test runner.

Copy link
Contributor

@wouterlucas wouterlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wouterlucas wouterlucas merged commit 900853c into lightning-js:main Dec 9, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants