fix: Fix RTT Clipping and improve RTT parent lookup #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfboeve
reviewed
Nov 21, 2024
Collaborator
jfboeve
left a comment
jfboeve
left a comment
There was a problem hiding this comment.
It looks like test rtt-dimension-2 is failing... does the test itself need updating? or did something not work as expected?
Contributor
Author
|
It’s because I turned on clipping on one of the rttNodes, to validate the change. We should keep it in, I’ll adjust the test so it aligns with the visual screenshots. |
jfboeve
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #452
Fixes #443