Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions examples/tests/clear-color-setting.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
/*
* If not stated otherwise in this file or this component's LICENSE file the
* following copyright and licenses apply:
*
* Copyright 2023 Comcast Cable Communications Management, LLC.
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import type { INode, RendererMain } from '@lightningjs/renderer';
import type { ExampleSettings } from '../common/ExampleSettings.js';
import { PageContainer } from '../common/PageContainer.js';

export async function automation(settings: ExampleSettings) {
// Snapshot all the pages
await (await test(settings)).snapshotPages();
}

export default async function test(settings: ExampleSettings) {
const { renderer } = settings;
const pageContainer = new PageContainer(settings, {
width: renderer.settings.appWidth,
height: renderer.settings.appHeight,
title: 'Dynamic Settings clearColor Tests',
});

pageContainer.pushPage(createTestCase(renderer, 'red', 0xff0000ff));
pageContainer.pushPage(createTestCase(renderer, 'green', 0x00ff00ff));
pageContainer.pushPage(createTestCase(renderer, 'transparent', 0x00000000));

await delay(200);
pageContainer.finalizePages();
return pageContainer;
}

function createTestCase(
renderer: RendererMain,
colorName: 'red' | 'green' | 'transparent',
color: number,
) {
return async function (page: INode) {
renderer.createTextNode({
mount: 0.5,
width: 400,
height: 400,
text: `Test passes if the background appears as ${colorName}`,
fontFamily: 'Ubuntu',
fontSize: 50,
x: renderer.settings.appWidth / 2,
y: renderer.settings.appHeight / 2,
parent: page,
});

renderer.setClearColor(color);
};
}

function delay(ms: number) {
return new Promise((resolve) => setTimeout(resolve, ms));
}
5 changes: 5 additions & 0 deletions src/core/Stage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,11 @@ export class Stage {
}
}

setClearColor(color: number) {
this.renderer.updateClearColor(color);
this.renderRequested = true;
}

updateFrameTime() {
const newFrameTime = getTimeStamp();
this.lastFrameTime = this.currentFrameTime;
Expand Down
1 change: 1 addition & 0 deletions src/core/renderers/CoreRenderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,4 +110,5 @@ export abstract class CoreRenderer {
abstract renderToTexture(node: CoreNode): void;
abstract getBufferInfo(): BufferInfo | null;
abstract getDefShaderCtr(): BaseShaderController;
abstract updateClearColor(color: number): void;
}
9 changes: 9 additions & 0 deletions src/core/renderers/canvas/CanvasCoreRenderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -331,4 +331,13 @@ export class CanvasCoreRenderer extends CoreRenderer {
getBufferInfo(): null {
return null;
}

/**
* Updates the clear color of the canvas renderer.
*
* @param color - The color to set as the clear color.
*/
updateClearColor(color: number) {
this.clearColor = color ? getRgbaComponents(color) : undefined;
}
}
40 changes: 35 additions & 5 deletions src/core/renderers/webgl/WebGlCoreRenderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import {
type CoreWebGlExtensions,
getWebGlParameters,
getWebGlExtensions,
type WebGlColor,
} from './internal/RendererUtils.js';
import { WebGlCoreCtxTexture } from './WebGlCoreCtxTexture.js';
import { Texture, TextureType } from '../../textures/Texture.js';
Expand Down Expand Up @@ -86,6 +87,11 @@ export class WebGlCoreRenderer extends CoreRenderer {
defaultShader: WebGlCoreShader;
quadBufferCollection: BufferCollection;

clearColor: WebGlColor = {
raw: 0x00000000,
normalized: [0, 0, 0, 0],
};

/**
* White pixel texture used by default when no texture is specified.
*/
Expand Down Expand Up @@ -127,10 +133,10 @@ export class WebGlCoreRenderer extends CoreRenderer {
options.contextSpy,
);
const glw = (this.glw = new WebGlContextWrapper(gl));

const color = getNormalizedRgbaComponents(clearColor);
glw.viewport(0, 0, canvas.width, canvas.height);
glw.clearColor(color[0]!, color[1]!, color[2]!, color[3]!);

this.updateClearColor(clearColor);

glw.setBlend(true);
glw.blendFunc(glw.ONE, glw.ONE_MINUS_SRC_ALPHA);

Expand Down Expand Up @@ -754,9 +760,9 @@ export class WebGlCoreRenderer extends CoreRenderer {
node.hasRTTupdates = false;
}

const color = getNormalizedRgbaComponents(this.stage.options.clearColor);
const clearColor = this.clearColor.normalized;
// Restore the default clear color
glw.clearColor(color[0]!, color[1]!, color[2]!, color[3]!);
glw.clearColor(clearColor[0], clearColor[1], clearColor[2], clearColor[3]);

// Bind the default framebuffer
glw.bindFramebuffer(null);
Expand Down Expand Up @@ -784,4 +790,28 @@ export class WebGlCoreRenderer extends CoreRenderer {
override getDefShaderCtr(): BaseShaderController {
return this.defShaderCtrl;
}

/**
* Updates the WebGL context's clear color and clears the color buffer.
*
* @param color - The color to set as the clear color, represented as a 32-bit integer.
*/
updateClearColor(color: number) {
if (this.clearColor.raw === color) {
return;
}
const glw = this.glw;
const normalizedColor = getNormalizedRgbaComponents(color);
glw.clearColor(
normalizedColor[0],
normalizedColor[1],
normalizedColor[2],
normalizedColor[3],
);
this.clearColor = {
raw: color,
normalized: normalizedColor,
};
glw.clear();
}
}
5 changes: 5 additions & 0 deletions src/core/renderers/webgl/internal/RendererUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -146,3 +146,8 @@ export function isHTMLImageElement(obj: unknown): obj is HTMLImageElement {
obj.constructor.name === 'HTMLImageElement'
);
}

export interface WebGlColor {
raw: number;
normalized: [number, number, number, number];
}
9 changes: 9 additions & 0 deletions src/main-api/Renderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -658,4 +658,13 @@ export class RendererMain extends EventEmitter {
rerender() {
throw new Error('Not implemented');
}

/**
* Sets the clear color for the stage.
*
* @param color - The color to set as the clear color.
*/
setClearColor(color: number) {
this.stage.setClearColor(color);
}
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading