Skip to content

fix: added missing error messages #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024
Merged

fix: added missing error messages #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/core/renderers/webgl/WebGlCoreShader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,14 @@ export abstract class WebGlCoreShader extends CoreShader {
fragmentSource,
);
if (!vertexShader || !fragmentShader) {
throw new Error();
throw new Error(
`Unable to create shader type: ${glw.FRAGMENT_SHADER}. Source: ${fragmentSource}`,
);
}

const program = createProgram(glw, vertexShader, fragmentShader);
if (!program) {
throw new Error();
throw new Error('Unable to create program');
}
this.program = program;

Expand Down
9 changes: 5 additions & 4 deletions src/core/renderers/webgl/internal/ShaderUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,11 @@ export function createShader(
) {
const shader = glw.createShader(type);
if (!shader) {
throw new Error();
throw new Error(`Unable to create shader type: ${type}. Source: ${source}`);
}
glw.shaderSource(shader, source);
glw.compileShader(shader);
const success = glw.getShaderParameter(shader, glw.COMPILE_STATUS);
const success = !!glw.getShaderParameter(shader, glw.COMPILE_STATUS);
if (success) {
return shader;
}
Expand All @@ -120,12 +120,13 @@ export function createProgram(
) {
const program = glw.createProgram();
if (!program) {
throw new Error();
throw new Error('Unable to create program');
}

glw.attachShader(program, vertexShader);
glw.attachShader(program, fragmentShader);
glw.linkProgram(program);
const success = glw.getProgramParameter(program, glw.LINK_STATUS);
const success = !!glw.getProgramParameter(program, glw.LINK_STATUS);
if (success) {
return program;
}
Expand Down
Loading