Skip to content

Render to Texture refactors #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2024
Merged

Render to Texture refactors #441

merged 3 commits into from
Nov 13, 2024

Conversation

@wouterlucas
Copy link
Contributor

@wouterlucas wouterlucas commented Nov 11, 2024 •
edited
Loading

Fixes #440

Todo:

  • Investigate why source -> destination texture relation adheres to original RTT node render state
  • Cache Parent RTT node for faster update behaviour

@wouterlucas
refactor: Improve RTT update graph and node insertion
e9cbe6b 
This commit enhances the Render-to-Texture (RTT) node handling by refining inheritance, update propagation, and insertion logic:

- RTT Inheritance Refactor: Streamlined RTT inheritance between child and parent nodes, ensuring a consistent RTT state across the hierarchy.
- Efficient RTT Clearing: Optimized the clearing of RTT nodes
- Update Loop Optimization: Removed duplicate `update()` calls for RTT nodes for improved performance
- Hierarchical RTT Node Insertion: Implemented an insertion strategy that respects the hierarchy when adding new RTT nodes, ensuring that child RTT nodes render before parent RTT nodes.
@wouterlucas
chore: Remove unnecessary RTT checks and cleanup code in CoreNode
87f2c61
@wouterlucas
Copy link
Contributor Author

wouterlucas commented Nov 13, 2024

Moving the caching optimization out to another PR so we can get this in & released.

@wouterlucas wouterlucas marked this pull request as ready for review November 13, 2024 11:56
@wouterlucas wouterlucas added this pull request to the merge queue Nov 13, 2024
@wouterlucas wouterlucas mentioned this pull request Nov 13, 2024
Closed
Merged via the queue into main with commit eb54ccc Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfboeve jfboeve jfboeve approved these changes

@erikhaandrikman erikhaandrikman Awaiting requested review from erikhaandrikman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Render to Texture flickering on Smart TVs

3 participants

@wouterlucas @jfboeve