🐛 [BUG] - isProductionEnv() not removed at build time

[chiefcll]

Description

When running a production build with Vite

export function isProductionEnvironment(): boolean {
  return import.meta.env && import.meta.env.PROD;
}

Is never fully removed from the build because import.meta.env.PROD is true and import.meta.env must be checked at runtime.

Alternatively, if you do:

function isDevEnv(): boolean {
  return !!(import.meta.env && import.meta.env.DEV);
}
export const isDev = isDevEnv() || false;

And check for isDev (not a function) - it will be able to remove all the functions because dev is false and the const becomes false at build time.

Currently all the assertTruthy are left in at runtime as well as isProductionEnvironement() checks. You may need to do isDev && assertTruthy to fully remove them

Reproduction URL

None

Reproduction steps

`vite build`
check output in dist directory

Screenshots

![DESCRIPTION](LINK.png)

Logs

Browsers

Other

Browser version

All

OS

No response

[wouterlucas]

The isProduction() check was added to make sure the Playground works with directly importing the Renderer from source.

Agree that we could convert this into a boolean with a simple early return, best case this will yield:

function assertTruthy(condition, message) {
  return;
}

in the production bundle.

As you point out to completely remove it from all the code we'll need to guard it with a

__DEV__ && assertTruthy

pattern, however that will trip everything as it will need to declare a global variable everywhere or the TS compiler will get mad. Let alone the impact this might have on the Playground doing a direct import.

This is hard no for me, instead I'd rather just cut down on assertTruthy's everywhere in the code. They where useful when the renderer was in early development stages, but at a lot of these places we can just start dropping them as they have no real use anymore.

I'll see if I can add a small change to get to the first case, we should slowly start dropping assertTruthy's - especially on mission critical paths.