Skip to content

All nodes are renderable #477

@chiefcll

Description

@chiefcll

I was looking to fix: #463 and noticed it wasn't happening any longer in main. This is because all nodes are now renderable due to
https://github.com/lightning-js/renderer/blob/main/src/core/CoreNode.ts#L771

Every node is being given a texture making it renderable. I assume you don't want that to be the case as every container node is now being rendered.

For instance:

const yellowRect = renderer.createNode({
    x: 300,
    y: 0,
    width: 100,
    height: 100,
    color: 0x00000000,
    parent: testRoot,
  });

Gets the defaultTexture, even though it shouldn't be rendered.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions