refactor: simplify isProduction check and remove unused assertions (#552)

Fixes #544 (partially) - will limit it to:

```
function assertTruthy(condition, message) {
  return;
}
```

In the production bundle. Removing it entirely is too intrusive right
now as we would need to inline every `assertTruthy` check.

Author: wouterlucas

examples/vite.config.ts

@@ -81,5 +81,8 @@ export default defineConfig(({ command, mode, isSsrBuild }) => {
         'Cross-Origin-Embedder-Policy': 'require-corp',
       },
     },
+    define: {
+      __DEV__: true,
+    },
   };
 });

src/core/CoreNode.ts

@@ -20,8 +20,8 @@
 import {
   assertTruthy,
   getNewId,
-  isProductionEnvironment,
   mergeColorAlphaPremultiplied,
+  isProductionEnvironment,
 } from '../utils.js';
 import type { TextureOptions } from './CoreTextureManager.js';
 import type { CoreRenderer } from './renderers/CoreRenderer.js';
@@ -1369,8 +1369,6 @@ export class CoreNode extends EventEmitter {
   }
 
   createRenderBounds(): void {
-    assertTruthy(this.stage);
-
     if (this.parent !== null && this.parent.strictBound !== undefined) {
       // we have a parent with a valid bound, copy it
       const parentBound = this.parent.strictBound;
@@ -2176,10 +2174,6 @@ export class CoreNode extends EventEmitter {
     this.props.parent = newParent;
     if (oldParent) {
       const index = oldParent.children.indexOf(this);
-      assertTruthy(
-        index !== -1,
-        "CoreNode.parent: Node not found in old parent's children!",
-      );
       oldParent.children.splice(index, 1);
       oldParent.setUpdateType(
         UpdateType.Children | UpdateType.ZIndexSortedChildren,

src/core/CoreTextNode.ts

@@ -34,7 +34,6 @@ import type {
 } from '../common/CommonTypes.js';
 import type { RectWithValid } from './lib/utils.js';
 import { assertTruthy } from '../utils.js';
-import { Matrix3d } from './lib/Matrix3d.js';
 
 export interface CoreTextNodeProps extends CoreNodeProps, TrProps {
   /**

src/core/TextureMemoryManager.ts

@@ -352,7 +352,7 @@ export class TextureMemoryManager {
         criticalThreshold: this.criticalThreshold,
       });
 
-      if (this.debugLogging === true || isProductionEnvironment() === false) {
+      if (this.debugLogging === true || isProductionEnvironment === false) {
         console.warn(
           `[TextureMemoryManager] Memory usage above critical threshold after cleanup: ${this.memUsed}`,
         );

src/main-api/Inspector.ts

@@ -172,7 +172,7 @@ export class Inspector {
   private scaleY = 1;
 
   constructor(canvas: HTMLCanvasElement, settings: RendererMainSettings) {
-    if (isProductionEnvironment()) return;
+    if (isProductionEnvironment === true) return;
 
     if (!settings) {
       throw new Error('settings is required');

src/main-api/Renderer.ts

@@ -19,7 +19,7 @@
 
 import type { ExtractProps, TextureMap } from '../core/CoreTextureManager.js';
 import { EventEmitter } from '../common/EventEmitter.js';
-import { assertTruthy, isProductionEnvironment } from '../utils.js';
+import { isProductionEnvironment } from '../utils.js';
 import { Stage } from '../core/Stage.js';
 import { CoreNode, type CoreNodeProps } from '../core/CoreNode.js';
 import { type CoreTextNodeProps } from '../core/CoreTextNode.js';
@@ -466,7 +466,7 @@ export class RendererMain extends EventEmitter {
     targetEl.appendChild(canvas);
 
     // Initialize inspector (if enabled)
-    if (inspector && !isProductionEnvironment()) {
+    if (inspector && isProductionEnvironment === false) {
       this.inspector = new inspector(canvas, resolvedSettings);
     }
   }
@@ -489,8 +489,6 @@ export class RendererMain extends EventEmitter {
   createNode<ShNode extends CoreShaderNode<any>>(
     props: Partial<INodeProps<ShNode>>,
   ): INode<ShNode> {
-    assertTruthy(this.stage, 'Stage is not initialized');
-
     const node = this.stage.createNode(props as Partial<CoreNodeProps>);
 
     if (this.inspector) {

src/utils.ts

@@ -64,6 +64,15 @@ export function createWebGLContext(
   return gl;
 }
 
+/**
+ * Checks if we're in a development environment or not.
+ *
+ * @returns
+ */
+declare const __DEV__: boolean;
+export const isProductionEnvironment =
+  typeof __DEV__ !== 'undefined' ? !__DEV__ : true;
+
 /**
  * Asserts a condition is truthy, otherwise throws an error
  *
@@ -80,7 +89,7 @@ export function assertTruthy(
   condition: unknown,
   message?: string,
 ): asserts condition {
-  if (isProductionEnvironment() === true) return;
+  if (isProductionEnvironment === true) return;
   if (!condition) {
     throw new Error(message || 'Assertion failed');
   }
@@ -230,15 +239,6 @@ export function getImageAspectRatio(width: number, height: number): number {
   return width / height;
 }
 
-/**
- * Checks import.meta if env is production
- *
- * @returns
- */
-export function isProductionEnvironment(): boolean {
-  return import.meta.env && import.meta.env.PROD;
-}
-
 /**
  * Returns a new unique ID
  */