Feature/v2 props object #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michielvandergeest
requested review from
jfboeve,
suresh-gangumalla and
uguraslan
jfboeve
reviewed
Apr 29, 2025
src/component/setup/props.js
Outdated
| for (let i = 0; i < propLength; i++) { | ||
| const prop = props[i] | ||
| if (typeof prop === 'string') { | ||
| out[prop] = { default: undefined } |
Collaborator
There was a problem hiding this comment.
I think these don't need the be storing objects when you're only using 1 property in them.. Or am I missing something?
Collaborator
Author
There was a problem hiding this comment.
this is for backwards compatibility - the old syntax could just be an array, in the new setup we're expecting an object. This piece of code rewrites it to the expected format
suresh-gangumalla
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.