-
Notifications
You must be signed in to change notification settings - Fork 2
Withdrawal finalization gas cost coverage #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
avsetsin
wants to merge
23
commits into
testnet-3
Choose a base branch
from
feature/withdrawal-fee
base: testnet-3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,176
−365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16a6098 to
d9f4858
Compare
…nfinalized stETH shares
…on; reorder imports
…pper into feature/withdrawal-fee
…holdBP and cap threshold below reserveRatioBP
Force FRT < RR
Bad debt check
arwer13
approved these changes
Nov 5, 2025
src/WithdrawalQueue.sol
Outdated
| uint256 ethToClaim, | ||
| uint256 stethSharesToRebalance, | ||
| uint256 stethToRebalance, | ||
| uint256 withdrawalFee |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename fee to smth more like finalizationGasRefund, ...Reimbursement, ...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.