This repository was archived by the owner on Jan 23, 2023. It is now read-only.
lep: create sockets early #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XXX-create-sockets-early.md
Outdated
Member
There was a problem hiding this comment.
I would suggest giving these more descriptive names, like uv_pipe_init_fd() or uv_pipe_init_from_fd().
Member
|
LGTM, but I would say that of course. @piscisaureus I remember that you had some misgivings about switching to early init? |
Member
Author
|
@bnoordhuis pushed an update with the issues fixed, the suggested names sounded indeed better. |
Member
|
LGTM, no comments. |
XXX-create-sockets-early.md
Outdated
There was a problem hiding this comment.
Should AF_WAT here read AF_WAIT or is it meant to hint that it's either AF_INET or AF_INET6 ? Might be better to just explicitly choose one here.
Member
Author
There was a problem hiding this comment.
I'll replace it with AF_??? or AF_UNSPEC to make it clearer.
saghul
force-pushed
the
create_sockets_early
branch
from
73e3482 to
7446bb9
Compare
5 tasks
Member
Author
|
Update! |
saghul
force-pushed
the
create_sockets_early
branch
from
7446bb9 to
d506df3
Compare
Member
Author
|
Accepted! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.