feat: support custom DNS resolvers #2435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `dns` config key that lets users specify an instance of the `DNS` interface from `@multiformats/dns`. This instance will be passed through to DNSADDR `multiaddr`s for use when the DNSLink TXT record is resolved.
Member
|
related to ipfs/helia-verified-fetch#13 (comment) |
SgtPooki
reviewed
Mar 11, 2024
Member
SgtPooki
left a comment
SgtPooki
left a comment
There was a problem hiding this comment.
mostly looks good. a few comments
SgtPooki
approved these changes
Mar 11, 2024
Member
SgtPooki
left a comment
SgtPooki
left a comment
There was a problem hiding this comment.
passing CI, so.. my comments are still valid from prior review, but approving because they're not major problems
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
dnsconfig key that lets users specify an instance of theDNSinterface from@multiformats/dns.This instance will be passed through to DNSADDR
multiaddrs for use when the DNSLink TXT record is resolved.Removes recursive DNSADDR resolution since this is now handled by
@multiformats/multiaddr.Change checklist