This repository was archived by the owner on Jul 21, 2023. It is now read-only.
feat: allow configurable validators and selectors #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
4 tasks
jacobheun
approved these changes
Nov 29, 2018
Contributor
jacobheun
left a comment
jacobheun
left a comment
There was a problem hiding this comment.
Other than a small nit, this looks good!
src/index.js
Outdated
| assert(sw, 'libp2p-kad-dht requires a instance of Switch') | ||
| options = options || {} | ||
| options.validators = options.validators || {} | ||
| options.selectors = options.selectors || {} |
Contributor
There was a problem hiding this comment.
This is unnecessary isn't it? The spread operator will ignore undefined and null.
Member
Author
There was a problem hiding this comment.
Just tested it. You are right, removed the fallback 😀
vasco-santos
deleted the
feat/allow-configurable-validators-and-selectors
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configurable validators and selectors. Users of
libp2p-kad-dhtmust be able to set their own validators and selectors.For instance, this is important for
js-ipfsto use/ipns/namespaces in the DHT