basichost: fix deadlock with addrs_manager #3348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
sukun/addrs-manager-deadlock
branch
3 times, most recently
from
8feca70 to
d3d206b
Compare
MarcoPolo
approved these changes
Jul 29, 2025
There are two issues with the current implementation: 1. Interface assertions for BasicHost methods don't work if the Routing option is selected. 2. AddrsFactory deadlocks when it depends on `host.AllAddrs` or `host.ConfirmedAddrs`. Fox fixing two, I've simplified the addrs update procedure to always update the addrs from only the background goroutine. This ensures that we need no locks while updating, so addrsfactory is free to depend on `ConfirmedAddrs`. See: https://github.com/ipshipyard/p2p-forge/blob/main/client/acme.go#L741 for a usecase.
sukunrt
force-pushed
the
sukun/addrs-manager-deadlock
branch
from
d3d206b to
d2884bb
Compare
sukunrt
added a commit
that referenced
this pull request
Jul 30, 2025
sukunrt
added a commit
that referenced
this pull request
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues with the current implementation:
host.AllAddrsorhost.ConfirmedAddrsFox fixing two, I've simplified the addrs update procedure to always update the addrs from only the background goroutine. This ensures that we need no locks while updating, so addrsfactory is free to depend on
ConfirmedAddrs. See: https://github.com/ipshipyard/p2p-forge/blob/main/client/acme.go#L741 for a usecase.