Qemu : add patch to fix bios linker loader assert #4204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhmSpectator
reviewed
Sep 4, 2024
...ches-4.15.0/16-imammedo_x86_acpi_use_offset_instead_of_pointer_when_using_build_header.patch
Show resolved
Hide resolved
shjala
force-pushed
the
fix_qemu_bios_assert
branch
from
6d81cee to
18f15b6
Compare
shjala
force-pushed
the
fix_qemu_bios_assert
branch
from
18f15b6 to
f6d82c4
Compare
This was referenced Sep 4, 2024
OhmSpectator
approved these changes
Sep 4, 2024
Member
OhmSpectator
left a comment
OhmSpectator
left a comment
There was a problem hiding this comment.
With the commit message fixed, looks fine.
shjala
force-pushed
the
fix_qemu_bios_assert
branch
from
f6d82c4 to
a6a6d43
Compare
shjala
force-pushed
the
fix_qemu_bios_assert
branch
2 times, most recently
from
96e2c63 to
17c161a
Compare
* Since commit c161dfb EVE runs VMs with TPM 2.0 device enabled, and it can cause VMs to fail to boot with the below assertion, reason is that if there is not enough contiguous memory available, the ACPI table is relocated but some table offsets, including tpm table are not updated. This is not always the case and the failure shows up only if the app assigned memory is too small (triggers the relocation), for example testing Ubuntu 20.04 and 22.04 images with memory lower than 4GB triggers the issue. * This patch fixes the bios linker loader assert: "bios_linker_loader_add_checksum: Assertion `start_offset < file->blob->len' failed." * This patch is base on the following commit, This has been part of the qemu mainline since v6.1.0 release : qemu/qemu@bb9feea Signed-off-by: Shahriyar Jalayeri <[email protected]>
shjala
force-pushed
the
fix_qemu_bios_assert
branch
from
17c161a to
5e510f5
Compare
Member
Author
|
Fixed typo in the commit message, added a bit more explanation. |
Member
|
As far as I understand, @rene has already tested it in his environment and it works) Nevertheless, we could wait for the test results... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit c161dfb EVE runs VMs with
TPM 2.0 device enabled, and it can cause VMs to fail to boot with the
below assertion, reason is that if there is not enough contiguous memory
available, the ACPI table is relocated but some table offsets, including
tpm table are not updated. This is not always the case and the failure
shows up only if the app assigned memory is too small (triggers the relocation),
for example testing Ubuntu 20.04 and 22.04 images with memory lower than
4GB triggers the issue.
This patch fixes the bios linker loader assert:
"bios_linker_loader_add_checksum: Assertion `start_offset < file->blob->len' failed."
This patch is base on the following commit, This has been part of the
qemu mainline since v6.1.0 release :
qemu/qemu@bb9feea