-
Notifications
You must be signed in to change notification settings - Fork 53
update vcom test to use the protobuf based API #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
6729627 to
d436ba5
Compare
Signed-off-by: Shahriyar Jalayeri <[email protected]>
52ac6ac to
656a66e
Compare
|
@milan-zededa Milan, can you help me find out what is wrong with my test, this test was working before but now when I try to ssh to the application I just get "failed to dial: dial tcp 127.0.0.1:8027: connect: connection refused". I haven't changed anything before the ssh establishes, new code is after that, but it just can't ssh to the app anymore, anything I can check on eve side to make sure it forwarding the port properly? also I don't see qemu listening on 8027 in EVE: |
eriknordmark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zpaett from Eden test issues causing failures, there is a failure which I assume the PR should fix:
--- FAIL: TestVcomLinkTpmRequestEK (0.02s)
|
@shjala How do you run the test locally? I tried to run it with: And it fails due to the SSH issue. However, everything is then deleted so I cannot investigate: Is it possible to stop this cleanup from happening? |
@eriknordmark yes, the test script works fine when I test it manually, but for some reason golang code can't ssh to the app anymore, I'm working on a fix. |
This is my eden setup:
what do need? I can change the code for sure. |
|
@milan-zededa ignore this. |
656a66e to
b29490c
Compare
|
@milan-zededa my bad I forgot for add port forwarding for 8027, this setup works: and test passes : |
uncleDecart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
It works locally, fails in CI : |
5b4979b to
66b7428
Compare
Should fo after lf-edge/eve#4502