Skip to content

Conversation

@shjala
Copy link
Member

@shjala shjala commented Aug 23, 2024

This is auxiliary package to make testing eve and vms easier, it offers a set of helper functions to create and manage eve and vm instances.

I moved it out of my other PRs, it would be great if we can get this review first so I can clean up my other tests (vcom, aziot and sec).

Copy link
Contributor

@milan-zededa milan-zededa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good start towards a framework for eden Go tests. Over time we will extend it with more methods (deploy network instance, check published info messages, use Eden-SDN, etc.) as we continue adding more Go tests.

@shjala shjala requested a review from milan-zededa August 23, 2024 08:50
@shjala
Copy link
Member Author

shjala commented Aug 23, 2024

I will squash commits when it is approved.

@shjala shjala requested a review from milan-zededa August 23, 2024 10:06
Copy link
Contributor

@milan-zededa milan-zededa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, just couple yetus complains to fix

This is auxiliary package to make testing eve and vms easier, it offers
a set of helper functions to create and manage eve and vm instances.

Signed-off-by: Shahriyar Jalayeri <[email protected]>
@milan-zededa milan-zededa merged commit 01d3a03 into lf-edge:master Aug 26, 2024
@uncleDecart
Copy link
Member

I'm late to the party I see :D Thanks @shjala , I think it's a great start, we will shape it as we go and add more tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants