Skip to content

Conversation

@Sab1e-dev
Copy link
Contributor

Added Output Report function and provided examples.
图片

Added Output Report function and provided examples.
@LeeNX
Copy link
Contributor

LeeNX commented Nov 20, 2024

Very nice @Sab1e-GitHub, thanks for the PR and pretty clean idea. I really like it. I wonder if improving the name from just enableOutputReport but to enableOutputVendorDefinedReport, as I am going to use your base to possible enabled PlayerLED indicators and possible LightBar function.

Another idea, can you write up a way that you can use the OutputReport, either python or command script or something else? Move people would use this feature, but I am thinking would be great to get into SDL or Linux BlueZ support.

@Sab1e-dev
Copy link
Contributor Author

Thank you very much for your recognition! Of course, you can modify the variable to enableOutputVendorDefinedReport.

Unfortunately, I am not familiar with SDL or Linux BlueZ, my apologies!

Additionally, I only have a C# test program. Would you need it?

@LeeNX
Copy link
Contributor

LeeNX commented Nov 23, 2024

Hey @lemmingDev, what do you think of the PR?

@Sab1e-GitHub adding the link to the C# example in the TestReceivingOutputReport.ino would be useful. Let me see if I can come up with a more general/portable example, so that as many people can test as possible.

@Sab1e-dev
Copy link
Contributor Author

@LeeNX I think you're right. I have added a link to the demo program in the TestReceivingOutputReport.ino file. Thank you very much for your suggestion!
@lemmingDev I hope you can accept this pr, it will be very helpful for others!

Copy link
Owner

@lemmingDev lemmingDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@lemmingDev lemmingDev merged commit e27a22d into lemmingDev:master Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants