Improve method that validates width and height values
#206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gracefully NaN and Infinity values.
own2pwn
reviewed
Oct 2, 2019
|
|
||
| internal func validateWidth(_ width: CGFloat, context: Context) -> Bool { | ||
| if width < 0 { | ||
| guard width.isNormal && width >= 0 else { |
There was a problem hiding this comment.
you can check just that width > 0, isNormal should handle case when the width is greater than zero. (just a quick remark)
own2pwn
approved these changes
Oct 2, 2019
|
|
||
| internal func validateHeight(_ height: CGFloat, context: Context) -> Bool { | ||
| if height < 0 { | ||
| guard height.isNormal && height >= 0 else { |
There was a problem hiding this comment.
also, maybe stick to if let a, b style and omit &&?
own2pwn
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve method that validates
widthandheightvalues. Now handle… gracefully NaN and Infinity values.