feat: Add support for setting the redis username when using redis persistence. #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
changed the title
Member
|
@hexedpackets Thank you for the contribution! This seems like a reasonable addition. It may take a little bit to review and validate. |
Member
|
@hexedpackets It appears that some changes will be needed to get the unit tests passing. |
Contributor
Author
Tests are passing but there was a typo in the type spec. I pushed up a fix for that and dialyzer is passing locally for me now. Side note - might be worth adding an instruction to run |
kinyoklion
approved these changes
Mar 17, 2025
kinyoklion
pushed a commit
that referenced
this pull request
Mar 19, 2025
🤖 I have created a release *beep* *boop* --- ## [3.6.0](v3.5.0...v3.6.0) (2025-03-17) ### Features * Add support for setting the redis username when using redis persistence. ([#142](#142)) ([c37fefd](c37fefd)) * Update certifi to 2.14.0 ([#144](#144)) ([69771cf](69771cf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Member
|
@hexedpackets Released in 3.6.0. Thank you for the contribution. Sorry about the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Describe the solution you've provided
eredissupports taking in a username for connections in addition to the password. The default isundefined, which will remain unchanged unlessredis_passwordis explicitly configured.