Please do not turn off default features for url

[hsivonen]

Bug Description

In d76b135 , sqlx-core turned off default features for url even though url didn't have default features at the time. This is disruptive now that url has introduced default features in order to manage catering to both the pre-existing MSRV-sensitive audience and to new no_std audience: servo/rust-url#992

Could you, please, remove default-features = false for url and publish a release?

Minimal Reproduction

rustup default 1.80
cargo new idna-992-repro
cd idna-992-repro/
cargo add sqlx
cargo check

Info

• SQLx version: 0.8.2
• SQLx features enabled: Default
• Database server and version: Not applicable.
• Operating system: Any
• rustc --version: 1.80.1

[hsivonen]

It appears that sqlx-core isn't the only SQLx crate with this problem but sqlx-macros-core has the same thing.

[qrilka]

This issue broke our CI :(

[abonander]

To fix, SQLx should upgrade the url dep to 2.5.2 and enable the std feature.

[hsivonen]

To fix, SQLx should upgrade the url dep to 2.5.2 and enable the std feature.

The std feature was introduced in 2.5.3.

[dertin]

This issue also broke our CI, and we had to do the following:

image: rust:1.80.1

Change this:

- cargo install sqlx-cli --no-default-features --features native-tls,mysql

To:

- git clone --branch v0.8.2 https://github.com/launchbadge/sqlx.git
- cd sqlx/sqlx-cli
- sed -i 's|url = { version = "2.2.2", default-features = false }|url = { version = "=2.5.2" }|' Cargo.toml
# (branch master) - sed -i '/^\[dependencies\]/a\url = "=2.5.2"' Cargo.toml 
- cargo install --path . --features native-tls,mysql
- cd .. && rm -rf sqlx
- cd .. && cargo sqlx --version

How does this look?

[hsivonen]

How does this look?

This issue asks enabling updates to url 2.5.3 on Rust < 1.81 when SQLx is also used. Your sed expression pins url 2.5.2, so it's not really a solution that would enable 2.5.3.

[dertin]

How does this look?

This issue asks enabling updates to url 2.5.3 on Rust < 1.81 when SQLx is also used. Your sed expression pins url 2.5.2, so it's not really a solution that would enable 2.5.3.

You're correct; I should have mentioned it's just a workaround.

[Kmshanley]

Hitting this issue as well

[N-T-K]

Hitting this issue too.