Skip to content

Conversation

@mrfade
Copy link

@mrfade mrfade commented Sep 28, 2025

Fix: incorrect URLs when forceRoot is set

When forceRoot was used, Route::domain() returned the full root including the scheme. Since uri() prepends the scheme separately, this resulted in broken URLs like https://https//site.com/..., especially when forceScheme was also applied.

This change makes domain() return only the host part of forcedRoot (without http:// or https://). That way, combining it with scheme() produces a valid URL.

This also fixes the issue reported in Issue #102

@Manavsaliya
Copy link

i think you can change Issue #102 to Fix #102 on last line

and you should write test cases for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants