Improve performance when retrieving Notion DB pages #6710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Contributor
rlancemartin
left a comment
rlancemartin
left a comment
There was a problem hiding this comment.
Thanks! Please run make format to resolve Lint errors.
Also, worth re-running the notebook to confirm?
AFAIK, we don't have a unit test for Notion loader so notebook is probably sufficient.
Contributor
Author
|
I appreciate you sorting the linting @dev2049! |
Contributor
Author
|
Notion DB document load test on 
This update change with the same dataset: 
|
Contributor
Nice work. Will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the existing
NotionDBLoaderto reduce duplicate calls to retrieve the metadata information.When calling out to retrieve the database objects, the property metadata is already returned as part of the request. This change removes the secondary call out, speeding up the process of loading documents from Notion.
@rlancemartin @eyurtsev