Change tags(str) to tags(dict) in mlflow_callback.py docs #6473
Conversation
|
@ArchimedesFTW is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |
| """Callback Handler that logs metrics and artifacts to mlflow server. | ||
| Parameters: | ||
| name (str): Name of the run. |
There was a problem hiding this comment.
while we're here, should these be run_name, experiment_name, and run_tags?
There was a problem hiding this comment.
I would suggest matching the style of MLflow, which uses the variables run_name and experiment_name :
https://mlflow.org/docs/latest/python_api/mlflow.html#mlflow.run
However, MLflow doesn't use the parameter run_tags so I suggest keeping that to 'tags'. The documentation explains that they are tags for the run.
It should be important to note that if we change the parameter names, people who build code with the MLflow callback and set those parameters will have breaking code when they update to a newer version.
3 participants
Fixes #6472
Who can review?
@agola11