Fixes #17 : Fixes when set -f option, no set -f option automatically #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weierophinney
requested changes
Aug 5, 2020
Member
weierophinney
left a comment
weierophinney
left a comment
There was a problem hiding this comment.
I've made one suggestion to how you check for the -f flag.
Additionally, we need tests demonstrating that the setParameters() method uses the parameter passed to the transport and NOT the sender and/or from address when it is provided; currently, you only demonstrate it is used when provided, and not used when not present, but not the additional case where it is not provided and falls through to the sender or from address.
weierophinney
added a commit
to samsonasik/laminas-mail
that referenced
this pull request
Aug 6, 2020
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
weierophinney
approved these changes
Aug 6, 2020
Member
weierophinney
left a comment
weierophinney
left a comment
There was a problem hiding this comment.
I've combined the two unit tests into a single one backed by a data provider. I think it's ready to 🚢 once tests have run.
…ically Signed-off-by: Abdul Malik Ikhsan <[email protected]>
…" conditions Signed-off-by: Abdul Malik Ikhsan <[email protected]>
This patch combines what was previously two test methods, `testNotSetOptionAutomaticallyOnLeadingF` and `testNotSetOptionAutomaticallyOnMiddleF`, into one method that better describes the behaviour (`testDoesNotInjectFromParameterFromSenderWhenFromOptionPresentInParameters`) and which uses a data provider to demonstrate various permutations of parameters containing a `-f` switch. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
weierophinney
added a commit
that referenced
this pull request
Aug 6, 2020
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
artemii-karkusha
pushed a commit
to artemii-karkusha/laminas-mail
that referenced
this pull request
May 24, 2023
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
artemii-karkusha
pushed a commit
to artemii-karkusha/laminas-mail
that referenced
this pull request
May 24, 2023
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-create zendframework/zend-mail#227 by @tzmfreedom Fixes #17 . Original PR description :