Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Conversation

@SantiagoPittella
Copy link
Collaborator

@SantiagoPittella SantiagoPittella commented Jul 19, 2023

Description

Change chain_id type to Felt252, allowing custom chains.

Closes #844

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

Codecov Report

Merging #847 (c4e227a) into main (3bbcf53) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
- Coverage   91.74%   91.73%   -0.02%     
==========================================
  Files          54       54              
  Lines       12842    12838       -4     
==========================================
- Hits        11782    11777       -5     
- Misses       1060     1061       +1     
Impacted Files Coverage Δ
src/definitions/block_context.rs 98.33% <100.00%> (-1.67%) ⬇️
src/execution/mod.rs 97.57% <100.00%> (ø)
src/syscalls/business_logic_syscall_handler.rs 77.95% <100.00%> (ø)
...calls/deprecated_business_logic_syscall_handler.rs 90.69% <100.00%> (ø)
src/syscalls/deprecated_syscall_handler.rs 98.36% <100.00%> (-0.01%) ⬇️
src/testing/mod.rs 100.00% <100.00%> (ø)
src/testing/state.rs 94.01% <100.00%> (ø)

@MegaRedHand MegaRedHand added this pull request to the merge queue Jul 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 20, 2023
@Oppen Oppen added this pull request to the merge queue Jul 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 20, 2023
@juanbono juanbono added this pull request to the merge queue Jul 20, 2023
Merged via the queue into main with commit dbf5906 Jul 20, 2023
@juanbono juanbono deleted the custom-chains-id branch July 31, 2023 23:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom chain IDs cannot be represented

6 participants