Skip to content

Conversation

@fedacking
Copy link
Contributor

@fedacking fedacking commented Oct 21, 2025

Motivation

The logs for engine calls forkchoice updated and get payload are useful to know when they are triggered to see the state of the client. They should be in info, and use the structured format.

Description

  • Made handle_forkchoice and get_engine log to info.
  • Made handle_forkchoice and get_engine log used structured logging format.
  • Made debug the "Snap sync in progress" message.
  • Added payload_id to the forkchoice block production log.

Progress towards issue #4950

Example Output

2025-10-22T15:03:49.600711Z INFO ethrex_rpc::engine::fork_choice: New fork choice request version="v3" head="0xc10720fe7dcbad99eb46fee520a63ce14bd44a354d86f4ebf76a5e81136278b8" safe="0x7539efbc7961746f1239ed9a003b7003e19b1d9e150db5c0a4194a5241f06d91" finalized="v0xf0a386ad788dc9efebef2dd9b46c677e82efe6bb1bd56023f06cb13babc024d6"

@fedacking fedacking requested a review from a team as a code owner October 21, 2025 21:17
@github-actions github-actions bot added the L1 Ethereum client label Oct 21, 2025
@fedacking fedacking mentioned this pull request Oct 21, 2025
15 tasks
@github-actions
Copy link

Lines of code report

Total lines added: 6
Total lines removed: 0
Total lines changed: 6

Detailed view
+----------------------------------------------------+-------+------+
| File                                               | Lines | Diff |
+----------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/engine/fork_choice.rs | 363   | +3   |
+----------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/engine/payload.rs     | 694   | +3   |
+----------------------------------------------------+-------+------+

@fedacking fedacking moved this to In Review in ethrex_l1 Oct 22, 2025
@fedacking fedacking added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit 1136d83 Oct 24, 2025
31 checks passed
@fedacking fedacking deleted the improve-engine-logging branch October 24, 2025 14:42
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants