Skip to content

Conversation

@jrchatruc
Copy link
Collaborator

@jrchatruc jrchatruc commented Oct 20, 2025

Motivation

We currently have a 1 hour ttl for our rocksdb WAL for no discernible reason, and I think it's better to leave it to rocksdb to configure until we find a reason to change it.

This 1 hour ttl is the main reason why the database size for our nodes drops massively an hour after snap sync finishes (in mainnet this drop is of more than 100 GB)

Description

Closes #issue_number

@github-actions github-actions bot added L1 Ethereum client L2 Rollup client labels Oct 20, 2025
@github-actions
Copy link

github-actions bot commented Oct 20, 2025

Lines of code report

Total lines added: 0
Total lines removed: 1
Total lines changed: 1

Detailed view
+-------------------------------------------+-------+------+
| File                                      | Lines | Diff |
+-------------------------------------------+-------+------+
| ethrex/crates/storage/store_db/rocksdb.rs | 1407  | -1   |
+-------------------------------------------+-------+------+

@jrchatruc jrchatruc marked this pull request as ready for review October 22, 2025 15:40
@jrchatruc jrchatruc requested a review from a team as a code owner October 22, 2025 15:40
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Oct 22, 2025
@jrchatruc jrchatruc added this pull request to the merge queue Oct 22, 2025
github-merge-queue bot pushed a commit that referenced this pull request Oct 22, 2025
**Motivation**

We currently have a 1 hour ttl for our rocksdb WAL for no discernible
reason, and I think it's better to leave it to rocksdb to configure
until we find a reason to change it.

This 1 hour ttl is the main reason why the database size for our nodes
drops massively an hour after snap sync finishes (in mainnet this drop
is of more than 100 GB)

**Description**

<!-- A clear and concise general description of the changes this PR
introduces -->

<!-- Link to issues: Resolves #111, Resolves #222 -->

Closes #issue_number
@jrchatruc jrchatruc removed this pull request from the merge queue due to a manual request Oct 22, 2025
@jrchatruc jrchatruc added this pull request to the merge queue Oct 22, 2025
Merged via the queue into main with commit b27f106 Oct 22, 2025
31 checks passed
@jrchatruc jrchatruc deleted the remove-wal-ttl branch October 22, 2025 17:21
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client L2 Rollup client

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants