Revert "Merge starkware-development"

[gabrielbosio]

Reverts #2172

[JulianGCalderon]

LGTM!

[github-actions]

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     24.512 s ±  0.042 s    [User: 23.701 s, System: 0.808 s]
  Range (min … max):   24.482 s … 24.542 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     25.459 s ±  0.009 s    [User: 24.730 s, System: 0.727 s]
  Range (min … max):   25.453 s … 25.466 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.04 ± 0.00 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     13.251 s ±  0.006 s    [User: 23.806 s, System: 0.826 s]
  Range (min … max):   13.246 s … 13.256 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.257 s ±  0.005 s    [User: 24.924 s, System: 0.785 s]
  Range (min … max):   14.254 s … 14.260 s    2 runs
 
Summary
  hyper_threading_main threads: 2 ran
    1.08 ± 0.00 times faster than hyper_threading_pr threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.023 s ±  0.276 s    [User: 35.937 s, System: 1.042 s]
  Range (min … max):    9.828 s … 10.218 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.481 s ±  0.454 s    [User: 37.785 s, System: 0.969 s]
  Range (min … max):   10.160 s … 10.802 s    2 runs
 
Summary
  hyper_threading_main threads: 4 ran
    1.05 ± 0.05 times faster than hyper_threading_pr threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.000 s ±  0.121 s    [User: 36.220 s, System: 1.053 s]
  Range (min … max):    9.914 s … 10.085 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.477 s ±  0.089 s    [User: 37.840 s, System: 0.994 s]
  Range (min … max):   10.414 s … 10.539 s    2 runs
 
Summary
  hyper_threading_main threads: 6 ran
    1.05 ± 0.02 times faster than hyper_threading_pr threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):      9.698 s ±  0.026 s    [User: 36.788 s, System: 1.104 s]
  Range (min … max):    9.680 s …  9.716 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.316 s ±  0.043 s    [User: 38.073 s, System: 1.001 s]
  Range (min … max):   10.285 s … 10.346 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.06 ± 0.01 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.025 s ±  0.206 s    [User: 36.486 s, System: 1.156 s]
  Range (min … max):    9.879 s … 10.170 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.125 s ±  0.003 s    [User: 38.654 s, System: 1.089 s]
  Range (min … max):   10.122 s … 10.127 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.01 ± 0.02 times faster than hyper_threading_pr threads: 16

[github-actions]

Benchmark Results for unmodified programs 🚀

Command	Mean [s]	Min [s]	Max [s]	Relative
base big_factorial	2.043 ± 0.006	2.035	2.057	1.00
head big_factorial	2.099 ± 0.007	2.085	2.106	1.03 ± 0.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base big_fibonacci	1.974 ± 0.005	1.968	1.984	1.00
head big_fibonacci	2.047 ± 0.010	2.035	2.063	1.04 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base blake2s_integration_benchmark	7.017 ± 0.012	7.004	7.041	1.00
head blake2s_integration_benchmark	7.761 ± 0.028	7.721	7.809	1.11 ± 0.00

Command	Mean [s]	Min [s]	Max [s]	Relative
base compare_arrays_200000	2.112 ± 0.025	2.093	2.179	1.00
head compare_arrays_200000	2.169 ± 0.008	2.161	2.184	1.03 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base dict_integration_benchmark	1.391 ± 0.015	1.366	1.409	1.00
head dict_integration_benchmark	1.402 ± 0.018	1.387	1.451	1.01 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base field_arithmetic_get_square_benchmark	1.166 ± 0.006	1.158	1.180	1.00
head field_arithmetic_get_square_benchmark	1.224 ± 0.004	1.217	1.230	1.05 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base integration_builtins	7.190 ± 0.121	7.104	7.415	1.00
head integration_builtins	7.911 ± 0.046	7.857	8.000	1.10 ± 0.02

Command	Mean [s]	Min [s]	Max [s]	Relative
base keccak_integration_benchmark	7.185 ± 0.020	7.141	7.209	1.00
head keccak_integration_benchmark	8.090 ± 0.050	8.014	8.170	1.13 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base linear_search	2.077 ± 0.020	2.052	2.116	1.00
head linear_search	2.158 ± 0.023	2.135	2.214	1.04 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_cmp_and_pow_integration_benchmark	1.469 ± 0.015	1.455	1.510	1.00
head math_cmp_and_pow_integration_benchmark	1.487 ± 0.011	1.477	1.514	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base math_integration_benchmark	1.413 ± 0.013	1.404	1.448	1.00
head math_integration_benchmark	1.432 ± 0.005	1.425	1.439	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base memory_integration_benchmark	1.188 ± 0.016	1.175	1.231	1.00
head memory_integration_benchmark	1.202 ± 0.005	1.195	1.210	1.01 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base operations_with_data_structures_benchmarks	1.484 ± 0.005	1.478	1.494	1.00
head operations_with_data_structures_benchmarks	1.561 ± 0.007	1.553	1.570	1.05 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base pedersen	519.1 ± 2.8	516.4	526.0	1.00
head pedersen	527.0 ± 1.7	524.8	530.7	1.02 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base poseidon_integration_benchmark	601.7 ± 5.7	595.8	614.7	1.00
head poseidon_integration_benchmark	616.8 ± 3.3	611.6	621.5	1.02 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base secp_integration_benchmark	1.756 ± 0.008	1.748	1.773	1.00
head secp_integration_benchmark	1.818 ± 0.010	1.806	1.843	1.04 ± 0.01

Command	Mean [ms]	Min [ms]	Max [ms]	Relative
base set_integration_benchmark	618.7 ± 1.7	616.5	622.1	1.00
head set_integration_benchmark	670.1 ± 4.1	664.7	675.3	1.08 ± 0.01

Command	Mean [s]	Min [s]	Max [s]	Relative
base uint256_integration_benchmark	3.995 ± 0.011	3.978	4.018	1.00
head uint256_integration_benchmark	4.248 ± 0.025	4.219	4.294	1.06 ± 0.01

[codecov]

Codecov Report

❌ Patch coverage is 96.57534% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.67%. Comparing base (5878bc3) to head (f7bdcae).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
vm/src/cairo_run.rs	72.72%	3 Missing ⚠️
vm/src/vm/runners/cairo_runner.rs	97.61%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2174      +/-   ##
==========================================
- Coverage   96.67%   96.67%   -0.01%     
==========================================
  Files         103      103              
  Lines       43944    43568     -376     
==========================================
- Hits        42483    42118     -365     
+ Misses       1461     1450      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.