Skip to content

Conversation

ksew1
Copy link
Contributor

@ksew1 ksew1 commented Jun 18, 2025

Make VirtualMachine::get_traceback_entries pub

Description

Made VirtualMachine::get_traceback_entries so it can be used in starknet-foundry backtrace feature

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@gabrielbosio
Copy link
Collaborator

gabrielbosio commented Jun 18, 2025

Hi, @ksew1, thanks for contributing! I have some questions:

  • Why does Scarb need this function for the backtrace feature?
  • How does this feature currently work without this function?

Also, as a side note: The VM also defines get_traceback which might be sufficient.

@ksew1
Copy link
Contributor Author

ksew1 commented Jul 7, 2025

Hi, @ksew1, thanks for contributing! I have some questions:

* Why does Scarb need this function for the backtrace feature?

* How does this feature currently work without this function?

Also, as a side note: The VM also defines get_traceback which might be sufficient.

How does this feature currently work without this function?

This is how it is currently done

Why does Scarb need this function for the backtrace feature?

We need pc as we map them to function names and lines using annotations for compiler

@gabrielbosio
Copy link
Collaborator

gabrielbosio commented Jul 23, 2025

@ksew1 I think this PR looks good but you need to sign your commits to get the CI working.

@ksew1 ksew1 force-pushed the make-traceback-entries-pub branch from e581f87 to 9a4b217 Compare July 24, 2025 10:49
@ksew1
Copy link
Contributor Author

ksew1 commented Jul 24, 2025

@ksew1 I think this PR looks good but you need to sign your commits to get the CI working.

Should be signed now

@gabrielbosio gabrielbosio added this pull request to the merge queue Jul 24, 2025
Merged via the queue into lambdaclass:main with commit f9780bc Jul 24, 2025
183 of 186 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants