Skip to content

Remove unused dependencies #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 4, 2025
Merged

Remove unused dependencies #2111

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6ab318c
Removed tower and cairo-lang-starknet
DiegoCivi May 30, 2025
d5a6206
Remove cairo1-run unused dependencies
DiegoCivi May 30, 2025
5de8bb9
Remove unused imports on wasm-demo and vm-cli
DiegoCivi May 30, 2025
e2c8c1c
Remove wasm_bindgen_test
DiegoCivi May 31, 2025
96a5492
Remove cairo-lang-starknet
DiegoCivi May 31, 2025
4919373
Remove getrandom dependency
DiegoCivi May 31, 2025
0e842e0
Revert "Remove getrandom dependency"
DiegoCivi Jun 1, 2025
f50aaa3
Remove with_mimalloc feature in cairo1-run
DiegoCivi Jun 2, 2025
3f5edea
Update CHANGELOG.md
DiegoCivi Jun 2, 2025
34135dd
Merge branch 'main' into chore/remove-unused-dependencies
gabrielbosio Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion cairo-vm-tracer/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ num-traits = { workspace = true }
axum = "0.6.18"
tokio = {version = "1.28.2", features = ["rt", "macros","rt-multi-thread"]}
serde = { workspace = true }
tower = { version = "0.4.13", features = ["util"] }
tower-http = { version = "0.4.0", features = ["full"] }
tracing = "0.1.37"
tracing-subscriber = "0.3.17"
Expand Down
6 changes: 1 addition & 5 deletions cairo1-run/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ cairo-vm = { workspace = true, features = ["std", "cairo-1-hints", "clap"] }
serde_json = { workspace = true }

cairo-lang-sierra-type-size = { version = "2.12.0-dev.0", default-features = false }
cairo-lang-sierra-ap-change = { version = "2.12.0-dev.0", default-features = false }
cairo-lang-sierra-gas = { version = "2.12.0-dev.0", default-features = false }
cairo-lang-starknet-classes.workspace = true
cairo-lang-sierra-to-casm.workspace = true
cairo-lang-compiler.workspace = true
cairo-lang-sierra.workspace = true
Expand All @@ -27,11 +24,10 @@ thiserror = { workspace = true, features = ["std"] }
bincode.workspace = true
assert_matches = "1.5.0"
rstest = "0.17.0"
mimalloc = { version = "0.1.37", default-features = false, optional = true }
num-traits = { version = "0.2", default-features = false }
num-bigint.workspace = true

[features]
default = ["with_mimalloc"]
with_mimalloc = ["dep:mimalloc"]
with_mimalloc = []
Copy link
Contributor Author

@DiegoCivi DiegoCivi May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this feature necessary? As far as I understand, it is not being used in cairo1-run

Copy link
Collaborator

@gabrielbosio gabrielbosio Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I think it's not used and it would be safe to remove it

Copy link
Contributor Author

@DiegoCivi DiegoCivi Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! f50aaa3

mod_builtin = ["cairo-vm/mod_builtin"]
3 changes: 0 additions & 3 deletions vm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ std = [
"dep:zip",
]
cairo-1-hints = [
"dep:cairo-lang-starknet",
"dep:cairo-lang-casm",
"dep:cairo-lang-starknet-classes",
"dep:ark-ff",
Expand All @@ -46,7 +45,6 @@ num-traits = { workspace = true }
num-integer = { workspace = true }
serde = { workspace = true }
serde_json = { workspace = true }
hex = { workspace = true }
bincode = { workspace = true }
starknet-crypto = { workspace = true }
sha3 = { workspace = true }
Expand All @@ -67,7 +65,6 @@ num-prime = { version = "0.4.3", features = ["big-int"], optional = true }
bitvec = { workspace = true }

# Dependencies for cairo-1-hints feature
cairo-lang-starknet = { workspace = true, optional = true }
cairo-lang-starknet-classes = { workspace = true, optional = true }
cairo-lang-casm = { workspace = true, optional = true }

Expand Down
Loading