Skip to content

fix: Add boundary tests for SecpSplitOutOfRange in secp_utils #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 29, 2025
Merged

fix: Add boundary tests for SecpSplitOutOfRange in secp_utils #2062

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bbb670c
fix: Add boundary tests for SecpSplitOutOfRange in secp_utils
VolodymyrBg Apr 7, 2025
98062a2
Merge branch 'main' into bgg
JulianGCalderon Apr 14, 2025
ec3ce4e
Update secp_utils.rs
VolodymyrBg Apr 14, 2025
731d42e
Update CHANGELOG.md
VolodymyrBg Apr 14, 2025
5da56c0
Update secp_utils.rs
VolodymyrBg Apr 14, 2025
6d7de3d
Merge branch 'main' into bgg
VolodymyrBg Apr 28, 2025
918fc32
remove optimizations
VolodymyrBg Apr 29, 2025
25487b2
Update CHANGELOG.md
VolodymyrBg Apr 29, 2025
5300149
Update CHANGELOG.md
VolodymyrBg Apr 29, 2025
5c53c00
Update CHANGELOG.md
VolodymyrBg Apr 29, 2025
36337ec
empty commit to fix CI
JulianGCalderon Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions vm/src/hint_processor/builtin_hint_processor/secp/secp_utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,14 +121,14 @@ mod tests {
.to_biguint()
.expect("Couldn't convert to BigUint"),
);
//TODO, Check SecpSplitutOfRange limit
let array_4 = bigint3_split(
&bigint_str!(
"773712524553362671811952647737125245533626718119526477371252455336267181195264"
)
.to_biguint()
.expect("Couldn't convert to BigUint"),
);

let max_value = &*BASE * &*BASE * &*BASE - BigUint::from(1u32);
let over_max_value = &*BASE * &*BASE * &*BASE;
let way_over_max_value = &*BASE * &*BASE * &*BASE * &*BASE;

let array_max = bigint3_split(&max_value);
let array_over_max = bigint3_split(&over_max_value);
let array_way_over_max = bigint3_split(&way_over_max_value);

assert_matches!(
array_1,
Expand Down Expand Up @@ -158,14 +158,24 @@ mod tests {
.expect("Couldn't convert to BigUint")
]
);

assert_matches!(
array_4,
Err(HintError::SecpSplitOutOfRange(bx)) if *bx == bigint_str!(
"773712524553362671811952647737125245533626718119526477371252455336267181195264"
)
.to_biguint()
.expect("Couldn't convert to BigUint")
array_max,
Ok(x) if x == [
BASE_MINUS_ONE.clone(),
BASE_MINUS_ONE.clone(),
BASE_MINUS_ONE.clone()
]
);

assert_matches!(
array_over_max,
Err(HintError::SecpSplitOutOfRange(bx)) if *bx == over_max_value
);

assert_matches!(
array_way_over_max,
Err(HintError::SecpSplitOutOfRange(bx)) if *bx == way_over_max_value
);
}
}
Loading