Skip to content

Conversation

yuvalsw
Copy link
Collaborator

@yuvalsw yuvalsw commented Apr 6, 2025

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

JulianGCalderon and others added 12 commits March 25, 2025 16:20
* Fix flow notation

* Fix dependency
* Add Commit Signing section

* Clarify that this only affects to internal branches

Co-authored-by: Julian Gonzalez Calderon <[email protected]>

---------

Co-authored-by: Julian Gonzalez Calderon <[email protected]>
Co-authored-by: Franco Giachetta <[email protected]>
* feat: implement VirtualMachine::is_accessed

Signed-off-by: Dori Medini <[email protected]>

* chore: refactor, test, changelog

Signed-off-by: Dori Medini <[email protected]>

---------

Signed-off-by: Dori Medini <[email protected]>
* feat: add get_current_step getter

Signed-off-by: Dori Medini <[email protected]>

* chore: changelog

Signed-off-by: Dori Medini <[email protected]>

* test: add coverage

Signed-off-by: Dori Medini <[email protected]>

---------

Signed-off-by: Dori Medini <[email protected]>
Added a label that triggers skipping of this job
* Bump Cairo to v2.12.0-dev.0

* Updte CHANGELOG.md

* Update lock

* Use as_str instead of as_ref

Compiler cannot infer type with as_ref

* Update entrypoint offset

Changes in the compiler must have changed casm generation
Copy link

github-actions bot commented Apr 6, 2025

**Hyper Thereading Benchmark results**




hyperfine -r 2 -n "hyper_threading_main threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_main' -n "hyper_threading_pr threads: 1" 'RAYON_NUM_THREADS=1 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 1
  Time (mean ± σ):     26.635 s ±  0.312 s    [User: 25.842 s, System: 0.791 s]
  Range (min … max):   26.415 s … 26.855 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 1
  Time (mean ± σ):     26.762 s ±  0.046 s    [User: 25.928 s, System: 0.832 s]
  Range (min … max):   26.730 s … 26.795 s    2 runs
 
Summary
  hyper_threading_main threads: 1 ran
    1.00 ± 0.01 times faster than hyper_threading_pr threads: 1




hyperfine -r 2 -n "hyper_threading_main threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_main' -n "hyper_threading_pr threads: 2" 'RAYON_NUM_THREADS=2 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 2
  Time (mean ± σ):     14.953 s ±  0.075 s    [User: 26.212 s, System: 0.857 s]
  Range (min … max):   14.901 s … 15.006 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 2
  Time (mean ± σ):     14.925 s ±  0.040 s    [User: 26.033 s, System: 0.894 s]
  Range (min … max):   14.897 s … 14.954 s    2 runs
 
Summary
  hyper_threading_pr threads: 2 ran
    1.00 ± 0.01 times faster than hyper_threading_main threads: 2




hyperfine -r 2 -n "hyper_threading_main threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_main' -n "hyper_threading_pr threads: 4" 'RAYON_NUM_THREADS=4 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 4
  Time (mean ± σ):     10.966 s ±  0.097 s    [User: 37.679 s, System: 0.944 s]
  Range (min … max):   10.898 s … 11.034 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 4
  Time (mean ± σ):     10.961 s ±  0.382 s    [User: 38.536 s, System: 1.059 s]
  Range (min … max):   10.691 s … 11.231 s    2 runs
 
Summary
  hyper_threading_pr threads: 4 ran
    1.00 ± 0.04 times faster than hyper_threading_main threads: 4




hyperfine -r 2 -n "hyper_threading_main threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_main' -n "hyper_threading_pr threads: 6" 'RAYON_NUM_THREADS=6 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 6
  Time (mean ± σ):     10.885 s ±  0.066 s    [User: 38.763 s, System: 1.031 s]
  Range (min … max):   10.838 s … 10.931 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 6
  Time (mean ± σ):     10.565 s ±  0.095 s    [User: 38.616 s, System: 1.054 s]
  Range (min … max):   10.498 s … 10.632 s    2 runs
 
Summary
  hyper_threading_pr threads: 6 ran
    1.03 ± 0.01 times faster than hyper_threading_main threads: 6




hyperfine -r 2 -n "hyper_threading_main threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_main' -n "hyper_threading_pr threads: 8" 'RAYON_NUM_THREADS=8 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 8
  Time (mean ± σ):     10.531 s ±  0.013 s    [User: 38.787 s, System: 1.011 s]
  Range (min … max):   10.522 s … 10.540 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 8
  Time (mean ± σ):     10.683 s ±  0.072 s    [User: 39.225 s, System: 1.106 s]
  Range (min … max):   10.633 s … 10.734 s    2 runs
 
Summary
  hyper_threading_main threads: 8 ran
    1.01 ± 0.01 times faster than hyper_threading_pr threads: 8




hyperfine -r 2 -n "hyper_threading_main threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_main' -n "hyper_threading_pr threads: 16" 'RAYON_NUM_THREADS=16 ./hyper_threading_pr'
Benchmark 1: hyper_threading_main threads: 16
  Time (mean ± σ):     10.580 s ±  0.345 s    [User: 39.435 s, System: 1.155 s]
  Range (min … max):   10.336 s … 10.825 s    2 runs
 
Benchmark 2: hyper_threading_pr threads: 16
  Time (mean ± σ):     10.710 s ±  0.159 s    [User: 40.120 s, System: 1.263 s]
  Range (min … max):   10.598 s … 10.822 s    2 runs
 
Summary
  hyper_threading_main threads: 16 ran
    1.01 ± 0.04 times faster than hyper_threading_pr threads: 16


Copy link

github-actions bot commented Apr 6, 2025

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.111 ± 0.014 2.095 2.139 1.00
head big_factorial 2.111 ± 0.012 2.099 2.134 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.047 ± 0.032 2.024 2.134 1.00 ± 0.02
head big_fibonacci 2.042 ± 0.012 2.031 2.074 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.544 ± 0.100 7.464 7.820 1.00
head blake2s_integration_benchmark 7.605 ± 0.063 7.500 7.696 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.155 ± 0.006 2.146 2.166 1.00
head compare_arrays_200000 2.166 ± 0.018 2.146 2.210 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.438 ± 0.020 1.428 1.495 1.00 ± 0.01
head dict_integration_benchmark 1.435 ± 0.004 1.430 1.441 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.204 ± 0.013 1.187 1.228 1.00
head field_arithmetic_get_square_benchmark 1.205 ± 0.013 1.193 1.238 1.00 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.572 ± 0.046 7.510 7.662 1.00
head integration_builtins 7.606 ± 0.090 7.536 7.855 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.998 ± 0.212 7.797 8.381 1.01 ± 0.03
head keccak_integration_benchmark 7.918 ± 0.087 7.839 8.068 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.151 ± 0.019 2.135 2.201 1.00 ± 0.01
head linear_search 2.145 ± 0.016 2.128 2.181 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.503 ± 0.005 1.496 1.514 1.00
head math_cmp_and_pow_integration_benchmark 1.523 ± 0.013 1.511 1.560 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.457 ± 0.007 1.445 1.469 1.00
head math_integration_benchmark 1.460 ± 0.012 1.445 1.488 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.207 ± 0.002 1.202 1.211 1.00
head memory_integration_benchmark 1.218 ± 0.008 1.207 1.239 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.569 ± 0.013 1.559 1.606 1.00 ± 0.01
head operations_with_data_structures_benchmarks 1.564 ± 0.004 1.559 1.570 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 531.1 ± 2.7 527.2 536.8 1.00
head pedersen 531.5 ± 1.8 529.3 535.9 1.00 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 631.9 ± 1.5 629.7 634.4 1.00 ± 0.01
head poseidon_integration_benchmark 630.1 ± 3.7 623.8 635.7 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.859 ± 0.042 1.834 1.971 1.01 ± 0.02
head secp_integration_benchmark 1.845 ± 0.010 1.832 1.861 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 663.1 ± 2.2 660.0 667.0 1.00
head set_integration_benchmark 693.3 ± 3.6 690.0 700.4 1.05 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.180 ± 0.042 4.129 4.249 1.00
head uint256_integration_benchmark 4.210 ± 0.046 4.157 4.283 1.01 ± 0.01

Copy link

codecov bot commented Apr 6, 2025

Codecov Report

Attention: Patch coverage is 96.73469% with 8 lines in your changes missing coverage. Please review.

Project coverage is 96.52%. Comparing base (3aed532) to head (6dfd853).
Report is 22 commits behind head on starkware-development.

Files with missing lines Patch % Lines
vm/src/vm/vm_core.rs 90.00% 7 Missing ⚠️
vm/src/vm/runners/cairo_runner.rs 98.66% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           starkware-development    #2052      +/-   ##
=========================================================
- Coverage                  96.53%   96.52%   -0.02%     
=========================================================
  Files                        102      102              
  Lines                      42720    42951     +231     
=========================================================
+ Hits                       41241    41458     +217     
- Misses                      1479     1493      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yuvalsw yuvalsw marked this pull request as ready for review April 6, 2025 21:56
@YairVaknin-starkware YairVaknin-starkware merged commit 2b5ceaf into starkware-development Apr 7, 2025
94 checks passed
@YairVaknin-starkware YairVaknin-starkware deleted the yuval/rebase_on_main branch April 7, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants