dev: make Memory::get pub

[enitrat]

Make Memory::get pub

Description

get becomes public, as now that memory itself is public, I want to be able to call get and get a MaybeRelocatable, without going through get_integer or get_relocatable.

Checklist

• Linked to Github Issue
• Unit tests added
• Integration tests added.
• This change requires new documentation.
  • Documentation has been added/updated.
  • CHANGELOG has been updated.

[JulianGCalderon]

Hi @enitrat, we prefer not to expose the get function, as the signature is a bit too complex and the Cow is there for legacy reasons.

Could you create a new function get_maybe_relocatable with the following signature, that internally calls get, and expose that one?

pub fn get_maybe_relocatable(&self, key: Relocatable)
    -> Result<MaybeRelocatable, MemoryError>;

[enitrat]

Could you create a new function get_maybe_relocatable with the following signature, that internally calls get, and expose that one?

pub fn get_maybe_relocatable(&self, key: Relocatable)
-> Result<MaybeRelocatable, MemoryError>;

This is what I had done locally while waiting for this to get merged. Would you want me implement this in this PR?

[JulianGCalderon]

Hey @enitrat. Could you add some unit tests? The coverage workflow would probably fail if not.

[enitrat]

Not sure how to run them locally:

$ make test

cairo1/bin/starknet-compile --allowed-libfuncs-list-name experimental_v0.1.0 cairo_programs/cairo-1-contracts/alloc_constant_size.cairo cairo_programs/cairo-1-contracts/alloc_constant_size.sierra
cairo1/bin/starknet-compile: cairo1/bin/starknet-compile: cannot execute binary file
make: *** [cairo_programs/cairo-1-contracts/alloc_constant_size.sierra] Error 126

[FrancoGiachetta]

Try running make deps (or deps-macos depending on you OS), and then run make test again.

[JulianGCalderon]

LGTM