Feature/contacts extension #141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged filter.js + prop.js together so that filter.js would become needless once/if use of (old) filter get adapted to (new) prop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During integration of 'object' and 'content' filter options to VCard requests, I did some required child and attribute enhancement to prop.js.
Later on I recognized that the required child and attribute functionality is more or less already in filter.js (but lacking namespace support).
Decided to merge filter.js and prop.js together into a common usable prop.js.
It's now used in the VCard request (for review). Could also be used for the other filtering stuff (which would make filter.js unnecessary), but would break backward compatibility due to the unified object names.
How to proceed?