Skip to content

fix: Grow subscriptions #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2024
Merged

fix: Grow subscriptions #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c56caad
fix: Grow subscriptions
gleip Nov 7, 2024
1ed5e3f
debug: fix test
gleip Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ export class Client<E extends Emitter = Emitter> extends Root {
batch.push(message);
}
if (batch.length > 0) listener.emit(eventName, batch);
events.stop();
}
}

Expand Down
5 changes: 4 additions & 1 deletion src/__tests__/Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,11 @@ describe('Testing Client class methods', () => {
test('Successful fetch events from stream', done => {
const payload = { data: { elapsed: 42 } };
const subscribe = new PassThrough({ objectMode: true });
const secondSubscribe = new PassThrough({ objectMode: true });
subscribe['stop'] = jest.fn();
secondSubscribe['stop'] = jest.fn();
jetstreamFetchMock.mockReturnValueOnce(subscribe);
jetstreamFetchMock.mockReturnValueOnce(new PassThrough({ objectMode: true }));
jetstreamFetchMock.mockReturnValueOnce(secondSubscribe);

const result = mathClient.getListener('Test', { batch: true });

Expand Down
Loading