Skip to content

Jasmine test suite #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

silasb
Copy link

@silasb silasb commented Mar 4, 2017

Using Jasmine so we can test sitemap-builder

@kuflash
Copy link
Owner

kuflash commented Mar 14, 2017

@silasb thank you for this PR. Can we run jasmine without test/run.js script? For example from npm scripts.

@silasb
Copy link
Author

silasb commented Mar 14, 2017 via email

@silasb
Copy link
Author

silasb commented Mar 14, 2017

Had time to look at this. I remember why I coded it this way. We need to use babel to transpile the test code. jasmine the command line utility doesn't support the import syntax that our tests use. The test/run.sh script is one solution to getting Jasmine to work with ES6 import syntax by running that script through babel-node. The other solution is to keep webpack around and transpile the code then run it through Jasmine, but that seems more ugly.

I already have npm scripts work via https://github.com/kuflash/react-router-sitemap/pull/47/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R19

@kuflash kuflash changed the base branch from master to develop May 30, 2017 16:22
@kuflash kuflash changed the base branch from develop to master May 30, 2017 16:22
@kuflash
Copy link
Owner

kuflash commented May 30, 2017

@silasb sorry for the long wait. I'm found problem for accept this PR. You should move your changes to develop branch in your fork repository and create new PR from your develop branch to develop branch this is repository. Can you do it?

@kuflash kuflash changed the base branch from master to develop May 30, 2017 16:32
@kuflash kuflash changed the base branch from develop to master May 30, 2017 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants