Skip to content

Conversation

@mctraffic
Copy link

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # GitHub BaseURL was not able to insert in the settings view, also in the pipeline configuration it was not possible to add the git ssh link (only https was allowed) therefore the regex was modified to enabled this setting.

Type of change

Please delete options that are not relevant.

  • Template (non-breaking change which adds a template)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • I've built the image and tested it on a kubernetes cluster

Test Configuration:

  • Operator Version:
  • Kubernetes Version:
  • Kubero CLI Version (if applicable):

Checklist:

  • I removed unnecessary debug logs
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I documented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@mms-gianni mms-gianni self-assigned this Jan 31, 2025
@mms-gianni mms-gianni changed the base branch from main to release/v2.4.7 January 31, 2025 09:45
@mms-gianni
Copy link
Member

Oh wow, this is much more than I expected.

Thank you. Looks good to me.

@mms-gianni mms-gianni merged commit 4c3a9eb into kubero-dev:release/v2.4.7 Jan 31, 2025
2 checks passed
@mms-gianni mms-gianni linked an issue Jan 31, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make baseUrl configurable for Github

3 participants