Skip to content

KEP-4800: move to beta #51474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

KEP-4800: move to beta #51474

merged 1 commit into from
Aug 6, 2025

Conversation

@ffromani
Copy link
Contributor

@ffromani ffromani commented Jul 2, 2025 •
edited
Loading

Description

Trivial graduation to beta. We expect no user-visible changes.

Issue

kubernetes/enhancements#5109

Closes: #N/A (issue 5109 will close once the feature is GA)

@k8s-ci-robot k8s-ci-robot added this to the 1.34 milestone Jul 2, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2025
@netlify
Copy link

netlify bot commented Jul 2, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit ed3d39a
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-vnext-staging/deploys/688a4ca698687600083e8187

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sjenning July 2, 2025 09:17
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 2, 2025
@ffromani ffromani changed the title node: graduate cpumanager prefer-align-cpus-by-uncorecache to beta KEP-4800: move to beta Jul 2, 2025
@ffromani ffromani mentioned this pull request Jul 2, 2025
Open
22 tasks
@netlify
Copy link

netlify bot commented Jul 2, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ed3d39a
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/688a4ca5ba398f00083074c3
😎 Deploy Preview https://deploy-preview-51474--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy
Copy link
Member

lmktfy commented Jul 2, 2025

Are the associated code changes merged?

@ffromani
Copy link
Contributor Author

ffromani commented Jul 2, 2025

/hold

@lmktfy no, the code changes are still outstanding. Holding to further reinforce.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2025
@ffromani
Copy link
Contributor Author

ffromani commented Jul 28, 2025

/hold cancel

all the code changes are now merged

@ffromani ffromani marked this pull request as ready for review July 28, 2025 07:58
@k8s-ci-robot k8s-ci-robot removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 28, 2025
@ffromani
Copy link
Contributor Author

ffromani commented Jul 30, 2025

/cc @swatisehgal

@k8s-ci-robot k8s-ci-robot requested a review from swatisehgal July 30, 2025 16:10
swatisehgal
swatisehgal approved these changes Jul 30, 2025
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Looks good from node perspective.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 30, 2025

LGTM label has been added.

Git tree hash: 7859651906b117c3ebe55f28dc0d62a374371746

@ffromani
node: graduate cpumanager prefer-align-cpus-by-uncorecache to beta
ed3d39a 
Trivial graduation to beta. We expect no user-visible changes.

Signed-off-by: Francesco Romani <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2025
@k8s-ci-robot k8s-ci-robot requested a review from swatisehgal July 30, 2025 16:47
@ffromani
Copy link
Contributor Author

ffromani commented Jul 30, 2025

thanks @swatisehgal unfortunately I forgot to bump the version number, should be fine now

@swatisehgal
Copy link
Contributor

swatisehgal commented Jul 30, 2025

thanks @swatisehgal unfortunately I forgot to bump the version number, should be fine now

No worries, I should have caught it.

Thanks for fixing!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 30, 2025

LGTM label has been added.

Git tree hash: e4390df575450390a39a87f3e13e617867511795

@michellengnx
Copy link
Contributor

michellengnx commented Aug 2, 2025

Hello @ffromani 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Wednesday August 6, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

@ffromani
Copy link
Contributor Author

ffromani commented Aug 4, 2025

/assign @katcosgrove

@reylejano
Copy link
Member

reylejano commented Aug 6, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano, swatisehgal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@k8s-ci-robot k8s-ci-robot merged commit 722327f into kubernetes:dev-1.34 Aug 6, 2025
6 checks passed
@ffromani ffromani deleted the kep-4800-1.34 branch August 6, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@sjenning sjenning Awaiting requested review from sjenning

@swatisehgal swatisehgal Awaiting requested review from swatisehgal

Assignees

@swatisehgal swatisehgal

@katcosgrove katcosgrove

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

1.34

Development

Successfully merging this pull request may close these issues.

7 participants

@ffromani @lmktfy @k8s-ci-robot @swatisehgal @michellengnx @reylejano @katcosgrove