Skip to content

Conversation

@serathius
Copy link
Contributor

Issue

/cc @fuweid

@k8s-ci-robot
Copy link
Contributor

@serathius: GitHub didn't allow me to request PR reviews from the following users: fuweid.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Issue

/cc @fuweid

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2025
@sftim
Copy link
Contributor

sftim commented Mar 3, 2025

/retitle [WIP] Add blog post for KEP-5116

@k8s-ci-robot k8s-ci-robot changed the title Draft blogpost for KEP-5116 [WIP] Add blog post for KEP-5116 Mar 3, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2025
@netlify
Copy link

netlify bot commented Mar 3, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e81ae73
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/680df88f0d21a60008428d3b
😎 Deploy Preview https://deploy-preview-49985--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@serathius
Copy link
Contributor Author

What's the expected deadline for feature blogposts? @sftim

@sftim
Copy link
Contributor

sftim commented Mar 19, 2025

If the blog article is part of post-release comms, best people to ask about deadlines are Release Comms (#release-comms on Slack).

@sn3hay
Copy link
Contributor

sn3hay commented Apr 3, 2025

Hi @serathius 👋 -- this is Sneha from the v1.33 Communications Team!

Just a friendly reminder that we are approaching the feature blog "ready for review" deadline: Monday 7th April 2025. By this deadline, your blog should be complete with all content finalized for review. If you are still working on it, please prioritize finishing it by the deadline mentioned above.

If you have any questions or need help, please don't hesitate to reach out to me or any of the Communications Team members. We are here to help you!

@serathius
Copy link
Contributor Author

We have a draft in google doc, let me move it here.

@serathius serathius force-pushed the kep-5116-blogpost branch from 81e13fa to cafa90e Compare April 7, 2025 18:34
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 7, 2025
@serathius serathius changed the title [WIP] Add blog post for KEP-5116 Add blog post for KEP-5116 Apr 7, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2025
@serathius
Copy link
Contributor Author

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Apr 7, 2025

technical content lgtm

Copy link
Contributor

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tengqm
Copy link
Contributor

tengqm commented Apr 8, 2025

Pending publication date...

Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The nits and accessibility issues are good to fix, but we can merge this and iterate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If SVG is available, please switch.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 62de231acff0b29b7075299c457ebf77c3297572

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2025
@k8s-ci-robot k8s-ci-robot requested review from liggitt and lmktfy April 22, 2025 10:59
Copy link
Contributor

@graz-dev graz-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serathius nice piece!
Just a small nit to adhere with our style guide.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9d204ffb36e0f56c7bf929817ef7171f4ef4807a

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2025
@k8s-ci-robot k8s-ci-robot requested a review from graz-dev April 27, 2025 09:27
@serathius
Copy link
Contributor Author

/assign @natalisucks

Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge as draft.

/lgtm
/approve


> _As a general rule of thumb, if you are dealing in messages larger than a megabyte each, it may be time to consider an alternate strategy._
>
> _From https://protobuf.dev/programming-guides/techniques/_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move the attribution outside the block quote.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is an SVG version available, we do prefer that.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bfc665fe51d0add8926ba370d03f44d2d8768a31

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8f610fc into kubernetes:main Apr 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.