-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Add blog post for KEP-5116 #49985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog post for KEP-5116 #49985
Conversation
|
@serathius: GitHub didn't allow me to request PR reviews from the following users: fuweid. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retitle [WIP] Add blog post for KEP-5116 |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
What's the expected deadline for feature blogposts? @sftim |
|
If the blog article is part of post-release comms, best people to ask about deadlines are Release Comms ( |
|
Hi @serathius 👋 -- this is Sneha from the v1.33 Communications Team! Just a friendly reminder that we are approaching the feature blog "ready for review" deadline: Monday 7th April 2025. By this deadline, your blog should be complete with all content finalized for review. If you are still working on it, please prioritize finishing it by the deadline mentioned above. If you have any questions or need help, please don't hesitate to reach out to me or any of the Communications Team members. We are here to help you! |
|
We have a draft in google doc, let me move it here. |
81e13fa to
cafa90e
Compare
|
/assign @liggitt |
|
technical content lgtm |
fuweid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Pending publication date... |
...nt/en/blog/_posts/YYYY-MM-DD-streaming-list-responses/YYYY-MM-DD-streaming-list-responses.md
Show resolved
Hide resolved
...nt/en/blog/_posts/YYYY-MM-DD-streaming-list-responses/YYYY-MM-DD-streaming-list-responses.md
Show resolved
Hide resolved
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The nits and accessibility issues are good to fix, but we can merge this and iterate.
...nt/en/blog/_posts/YYYY-MM-DD-streaming-list-responses/YYYY-MM-DD-streaming-list-responses.md
Outdated
Show resolved
Hide resolved
...nt/en/blog/_posts/YYYY-MM-DD-streaming-list-responses/YYYY-MM-DD-streaming-list-responses.md
Outdated
Show resolved
Hide resolved
...nt/en/blog/_posts/YYYY-MM-DD-streaming-list-responses/YYYY-MM-DD-streaming-list-responses.md
Outdated
Show resolved
Hide resolved
...nt/en/blog/_posts/YYYY-MM-DD-streaming-list-responses/YYYY-MM-DD-streaming-list-responses.md
Outdated
Show resolved
Hide resolved
...nt/en/blog/_posts/YYYY-MM-DD-streaming-list-responses/YYYY-MM-DD-streaming-list-responses.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If SVG is available, please switch.
|
LGTM label has been added. Git tree hash: 62de231acff0b29b7075299c457ebf77c3297572
|
6e60521 to
eae8262
Compare
...nt/en/blog/_posts/YYYY-MM-DD-streaming-list-responses/YYYY-MM-DD-streaming-list-responses.md
Outdated
Show resolved
Hide resolved
graz-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@serathius nice piece!
Just a small nit to adhere with our style guide.
/lgtm
...nt/en/blog/_posts/YYYY-MM-DD-streaming-list-responses/YYYY-MM-DD-streaming-list-responses.md
Outdated
Show resolved
Hide resolved
|
LGTM label has been added. Git tree hash: 9d204ffb36e0f56c7bf929817ef7171f4ef4807a
|
Co-authored-by: Ryota <[email protected]>
eae8262 to
e81ae73
Compare
|
/assign @natalisucks |
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge as draft.
/lgtm
/approve
...nt/en/blog/_posts/YYYY-MM-DD-streaming-list-responses/YYYY-MM-DD-streaming-list-responses.md
Show resolved
Hide resolved
|
|
||
| > _As a general rule of thumb, if you are dealing in messages larger than a megabyte each, it may be time to consider an alternate strategy._ | ||
| > | ||
| > _From https://protobuf.dev/programming-guides/techniques/_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: move the attribution outside the block quote.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is an SVG version available, we do prefer that.
|
LGTM label has been added. Git tree hash: bfc665fe51d0add8926ba370d03f44d2d8768a31
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lmktfy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue
/cc @fuweid