Skip to content

Conversation

@aramase
Copy link
Member

@aramase aramase commented Feb 27, 2025

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2025
@aramase
Copy link
Member Author

aramase commented Feb 27, 2025

/area blog
/sig auth

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2025
@netlify
Copy link

netlify bot commented Feb 27, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 206c021
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/680be0a74b645400084d29ef
😎 Deploy Preview https://deploy-preview-49924--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@enj enj added this to SIG Auth Feb 27, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Auth Feb 27, 2025
@aramase aramase force-pushed the aramase/d/kep_4412_alpha_blog branch from 367ed3f to d77bb28 Compare April 3, 2025 22:22
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 3, 2025
@aramase aramase marked this pull request as ready for review April 3, 2025 22:23
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2025
@aramase aramase moved this from Needs Triage to In Review in SIG Auth Apr 3, 2025
@aramase
Copy link
Member Author

aramase commented Apr 3, 2025

/assign enj liggitt

@aramase aramase force-pushed the aramase/d/kep_4412_alpha_blog branch from d77bb28 to 245e8a2 Compare April 9, 2025 16:47
@aramase aramase requested a review from stlaz April 10, 2025 00:53
Copy link
Member

@rytswd rytswd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do more full review later, but just wanted to make sure the draft state is handled. That way, once the write-up + review is fully complete, you can leave the rest of publication handling to the Release Comms team 👍

@haircommander
Copy link
Contributor

/lgtm

(sig-node)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dc2aa528c6d421c664c8a6690e0bb98379b10164

Copy link
Contributor

@graz-dev graz-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aramase nice piece!
Just a small suggestion to adhere with our style guide!

Signed-off-by: Anish Ramasekar <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2025
@aramase
Copy link
Member Author

aramase commented Apr 25, 2025

@aramase nice piece! Just a small suggestion to adhere with our style guide!

thanks @graz-dev! I've updated it.

Copy link
Contributor

@graz-dev graz-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d49d9ad113cbd78fe66ab8ee41eadbd00c203984

@aramase
Copy link
Member Author

aramase commented Apr 30, 2025

@rytswd @Udi-Hofesh Is there anything left before we can merge this blog? Based on this project view, it looks like the blog is scheduled for May 7th — is that correct?

@lmktfy
Copy link
Member

lmktfy commented May 1, 2025

Let's merge it as draft. I think the article title should change to match the others; the next PR can cover that.

Your next step @aramase (or another contributor can do it) is to open a PR to mark it draft and set a publication date. Look at the most recent commits for other, published post-release blog articles to see how that's done.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lmktfy, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2025
@k8s-ci-robot k8s-ci-robot merged commit 682011d into kubernetes:main May 1, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Closed / Done in SIG Auth May 1, 2025
@rytswd
Copy link
Member

rytswd commented May 1, 2025

@aramase you can leave it for the Comms team to make a PR for the publication date change, as well as final adjustments if necessary

@aramase aramase deleted the aramase/d/kep_4412_alpha_blog branch May 1, 2025 15:12
@aramase
Copy link
Member Author

aramase commented May 1, 2025

@aramase you can leave it for the Comms team to make a PR for the publication date change, as well as final adjustments if necessary

I missed this message. I opened a follow-up PR to add Kubernetes v1.33 to the title and slug: #50756.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

9 participants