Skip to content

Removing docs for Windows hostNetwork support for v1.33 #49905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

Removing docs for Windows hostNetwork support for v1.33 #49905

merged 2 commits into from
Apr 9, 2025

Conversation

@marosset
Copy link
Contributor

@marosset marosset commented Feb 25, 2025

Description

Windows hostNetwork support is being withdrawn from alpha in v.133 release and this PR updates k/website acordingly

Issue

kubernetes/enhancements#3503

Closes: #

/sig windows network

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/network Categorizes an issue or PR as relevant to SIG Network. language/en Issues or PRs related to English language labels Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 25, 2025
@netlify
Copy link

netlify bot commented Feb 25, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit f3e39d3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67f556f4bdfbc60008780d68

@marosset marosset changed the title Removing docs for Windows hostNetwork support for v1.33 WIP - Removing docs for Windows hostNetwork support for v1.33 Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2025
@marosset marosset mentioned this pull request Feb 25, 2025
Closed
8 tasks
@netlify
Copy link

netlify bot commented Feb 25, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f3e39d3
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67f556f40d54240008a88e7c
😎 Deploy Preview https://deploy-preview-49905--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim
sftim reviewed Feb 27, 2025
View reviewed changes
@marosset marosset force-pushed the scrub-windows-hostnetwork-docs branch from af0760b to 41c6062 Compare March 21, 2025 18:10
@marosset marosset changed the title WIP - Removing docs for Windows hostNetwork support for v1.33 Removing docs for Windows hostNetwork support for v1.33 Mar 21, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2025
sftim
sftim reviewed Mar 22, 2025
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Suggested tweaks are optional.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 22, 2025

LGTM label has been added.

Git tree hash: 995edd1ca0f4363366af71db6158345569a496a0

@rayandas
Copy link
Member

rayandas commented Apr 4, 2025

Hello @marosset 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT.
This documentation appears to still require and approval. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs.
The status of this enhancement is marked as At risk for docs freeze. Thank you!

@tengqm
Copy link
Contributor

tengqm commented Apr 5, 2025

Please provide a link to the upstream (kubernetes/kubernetes) source code change so that the reviewers know whether this docs change is okay to be kicked in.

@marosset
Copy link
Contributor Author

marosset commented Apr 8, 2025

Here are the code changes for the additions related to this enhancement: kubernetes/kubernetes#112961
Here are the code changes for the removals related to this enhancement: kubernetes/kubernetes#130250

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sftim April 8, 2025 17:03
@jsturtevant
Copy link
Contributor

jsturtevant commented Apr 8, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 8, 2025

LGTM label has been added.

Git tree hash: af5d5d1646a714d82856b94b4574b8d0e46c260b

@rayandas
Copy link
Member

rayandas commented Apr 8, 2025

Tagging @lmktfy for an approval.

@tengqm
Copy link
Contributor

tengqm commented Apr 9, 2025

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2025
@tengqm tengqm added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 9, 2025
@rayandas
Copy link
Member

rayandas commented Apr 9, 2025

Since the approve label got removed by the tide label, I am approving it.
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rayandas, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9e160e8 into kubernetes:dev-1.33 Apr 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jayunit100 jayunit100 Awaiting requested review from jayunit100

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@sftim sftim Awaiting requested review from sftim

Assignees

@jsturtevant jsturtevant

@sftim sftim

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@marosset @k8s-ci-robot @rayandas @tengqm @jsturtevant @sftim