Skip to content

Conversation

@danwinship
Copy link
Contributor

Updates documentation to reflect the fact that Endpoints are now officially deprecated in 1.33 (KEP-4974).

This includes some updates to the EndpointSlice documentation to get rid of some historical baggage and focus on describing the API as it is now. (It does not add any of the missing information to the section about topology because that will need to be updated for KEP-3015 anyway so I'll just fix it all then.)

There are a lot of instances of the word "endpoints" in the documentation, but a lot of them refer to the generic concept. I think I've fixed most of them at least...

/label tide/merge-method-squash

- FQDN is not a supported AddressType

- Update documentation around `serving` vs `ready` to just explain how
  it works now, without the historical context. (In particular,
  describe `serving` first, and then explain `ready` as being almost
  the same thing as `serving` rather than vice versa).

- Fix feature-state version macro for `terminating`

- Remove a note about some deprecated v1beta1 EndpointSlice fields
  that is just confusing if you didn't know that v1beta1 had a
  different topology API.

- Remove the "Comparison with Endpoints"/"Motivation" section.
@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Feb 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 19, 2025
@netlify
Copy link

netlify bot commented Feb 19, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 0d29bb5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67f5502e5cd9f80008681da2

@@ -1,17 +0,0 @@
---
title: Endpoints
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could have a glossary entry for endpoint rather than Endpoints?

And then the revised entry could mention EndpointSlice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, effectively replace both existing glossary entries with the new combined one? Is there any way to make the old ones redirect? Or should I keep the old ones too, but just have basically the same information in all three?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the glossary entry id is endpoint. So we / you could:

  • explain what we mean by the term endpoint
  • mention EndpointSlices
  • find everywhere this glossary term is used within English docs, and check that the changes haven't made the page misleading
    • minimum viable rewrites where needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the glossary entry id is endpoint

The filename is endpoint.md, though it says id: endpoints inside... But people seem to link to it as term_id="endpoint" and it works so I'm not sure what's going on there...

Copy link
Contributor Author

@danwinship danwinship Mar 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find everywhere this glossary term is used within English docs

In main, the only links to the endpoint glossary entry are here and here, which are both using the glossary entry to explain Endpoints resources specifically, not endpoints as a concept in general. (And both links go away in this PR.)

explain what we mean by the term endpoint

So this is tricky because the docs use the word "endpoint" with a lowercase "e" to refer not just to the Endpoints/EndpointSlice thing, but also to refer to REST APIs ("The Kubernetes API server serves an aggregated OpenAPI v2 spec via the /openapi/v2 endpoint.") So I'm not sure we want a generic glossary entry for "endpoint" unless it's going to cover both meanings?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cover both meanings

We can do that. I'm all over doing so.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This glossary should be preserved.
We are breaking the site build when removing this file.
In addition to that, having a glossary for "endpoint" in the general sense is good.

@Urvashi0109
Copy link
Contributor

Urvashi0109 commented Apr 3, 2025

Hello @danwinship 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT.
This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you!

@rayandas
Copy link
Member

rayandas commented Apr 8, 2025

@danwinship 1.33 Docs team here! This PR is still not in a shape to merge. Just a friendly reminder, Docs Freeze which is on 8th April, 2025 18:00 PDT

@rayandas
Copy link
Member

rayandas commented Apr 8, 2025

/retest

@danwinship danwinship force-pushed the deprecate-endpoints branch from a57fa8d to 0d29bb5 Compare April 8, 2025 16:34
@danwinship
Copy link
Contributor Author

Brought back the endpoint glossary item, with a generic definition, though there are no in-tree links to it from the English docs.

@netlify
Copy link

netlify bot commented Apr 8, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0d29bb5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67f5502e714a42000891f3d0
😎 Deploy Preview https://deploy-preview-49831--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rayandas
Copy link
Member

rayandas commented Apr 8, 2025

@bowei Could you please give a technical review?

@rayandas
Copy link
Member

rayandas commented Apr 8, 2025

The changes are addressed. Just need another quick review from Docs @tengqm @lmktfy Thanks!

@danwinship
Copy link
Contributor Author

/assign @aojea

@rayandas
Copy link
Member

rayandas commented Apr 9, 2025

Hello @danwinship 👋, 1.33 Docs team here. This PR did not meet deadline for docs freeze. Enhancements without required documentation may be removed from the current release. If you still wish to include this enhancement in 1.33, please file an exception request. Thanks!

full_link:
short_description: >
Endpoints track the IP addresses of Pods with matching Service selectors.
An endpoint of a Service is one of the Pods (or external servers) that implements the Service.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

despite is deprecated the API exist, so I think the old definition still applies

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, it was dicussed here #49831 (comment) , it seems is the preference to follow this path

@aojea
Copy link
Member

aojea commented Apr 9, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6eadb136a74de61938124dce95d87098c60fddc2

@tengqm
Copy link
Contributor

tengqm commented Apr 9, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit 649bda2 into kubernetes:dev-1.33 Apr 9, 2025
6 checks passed
@rayandas
Copy link
Member

rayandas commented Apr 9, 2025

Marking this PR as tracked for Docs freeze. Thanks!

@danwinship danwinship deleted the deprecate-endpoints branch April 9, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants