-
Couldn't load subscription status.
- Fork 15.1k
Update docs for deprecation of Endpoints API #49831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for deprecation of Endpoints API #49831
Conversation
- FQDN is not a supported AddressType - Update documentation around `serving` vs `ready` to just explain how it works now, without the historical context. (In particular, describe `serving` first, and then explain `ready` as being almost the same thing as `serving` rather than vice versa). - Fix feature-state version macro for `terminating` - Remove a note about some deprecated v1beta1 EndpointSlice fields that is just confusing if you didn't know that v1beta1 had a different topology API. - Remove the "Comparison with Endpoints"/"Motivation" section.
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
| @@ -1,17 +0,0 @@ | |||
| --- | |||
| title: Endpoints | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could have a glossary entry for endpoint rather than Endpoints?
And then the revised entry could mention EndpointSlice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, effectively replace both existing glossary entries with the new combined one? Is there any way to make the old ones redirect? Or should I keep the old ones too, but just have basically the same information in all three?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the glossary entry id is endpoint. So we / you could:
- explain what we mean by the term endpoint
- mention EndpointSlices
- find everywhere this glossary term is used within English docs, and check that the changes haven't made the page misleading
- minimum viable rewrites where needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the glossary entry id is
endpoint
The filename is endpoint.md, though it says id: endpoints inside... But people seem to link to it as term_id="endpoint" and it works so I'm not sure what's going on there...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
find everywhere this glossary term is used within English docs
In main, the only links to the endpoint glossary entry are here and here, which are both using the glossary entry to explain Endpoints resources specifically, not endpoints as a concept in general. (And both links go away in this PR.)
explain what we mean by the term endpoint
So this is tricky because the docs use the word "endpoint" with a lowercase "e" to refer not just to the Endpoints/EndpointSlice thing, but also to refer to REST APIs ("The Kubernetes API server serves an aggregated OpenAPI v2 spec via the /openapi/v2 endpoint.") So I'm not sure we want a generic glossary entry for "endpoint" unless it's going to cover both meanings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cover both meanings
We can do that. I'm all over doing so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This glossary should be preserved.
We are breaking the site build when removing this file.
In addition to that, having a glossary for "endpoint" in the general sense is good.
|
Hello @danwinship 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT. |
|
@danwinship 1.33 Docs team here! This PR is still not in a shape to merge. Just a friendly reminder, Docs Freeze which is on 8th April, 2025 18:00 PDT |
|
/retest |
a57fa8d to
0d29bb5
Compare
|
Brought back the |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@bowei Could you please give a technical review? |
|
/assign @aojea |
|
Hello @danwinship 👋, 1.33 Docs team here. This PR did not meet deadline for docs freeze. Enhancements without required documentation may be removed from the current release. If you still wish to include this enhancement in 1.33, please file an exception request. Thanks! |
| full_link: | ||
| short_description: > | ||
| Endpoints track the IP addresses of Pods with matching Service selectors. | ||
| An endpoint of a Service is one of the Pods (or external servers) that implements the Service. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
despite is deprecated the API exist, so I think the old definition still applies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, it was dicussed here #49831 (comment) , it seems is the preference to follow this path
|
/lgtm |
|
LGTM label has been added. Git tree hash: 6eadb136a74de61938124dce95d87098c60fddc2
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Marking this PR as tracked for Docs freeze. Thanks! |
Updates documentation to reflect the fact that Endpoints are now officially deprecated in 1.33 (KEP-4974).
This includes some updates to the EndpointSlice documentation to get rid of some historical baggage and focus on describing the API as it is now. (It does not add any of the missing information to the section about topology because that will need to be updated for KEP-3015 anyway so I'll just fix it all then.)
There are a lot of instances of the word "endpoints" in the documentation, but a lot of them refer to the generic concept. I think I've fixed most of them at least...
/label tide/merge-method-squash