Skip to content

Multiple Service CIDRs - KEP 1880 #49746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 5, 2025
Merged

Multiple Service CIDRs - KEP 1880 #49746

merged 5 commits into from
Apr 5, 2025

Conversation

@aojea
Copy link
Member

@aojea aojea commented Feb 13, 2025

Description

Multiple Service CIDRs #1880 - GA

Issue

kubernetes/enhancements#1880

Closes: #

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 13, 2025
@aojea aojea mentioned this pull request Feb 13, 2025
Closed
12 tasks
@netlify
Copy link

netlify bot commented Feb 13, 2025 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 0e17266
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67e3c6163b573300086b0cc2

@netlify
Copy link

netlify bot commented Feb 13, 2025 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0e17266
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67e3c616689e3c0008025c0b
😎 Deploy Preview https://deploy-preview-49746--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 24, 2025
@aojea aojea marked this pull request as ready for review March 24, 2025 09:36
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2025
@aojea
Copy link
Member Author

aojea commented Mar 24, 2025

/assign @thockin @danwinship

thockin
thockin reviewed Mar 24, 2025
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 24, 2025

LGTM label has been added.

Git tree hash: 99c76db43ee7d1939009babd068fa9de8873715b

tengqm
tengqm reviewed Mar 26, 2025
View reviewed changes
@aojea @tengqm
Update content/en/docs/reference/command-line-tools-reference/feature…
4ada092 
…-gates/DisableAllocatorDualWrite.md

Co-authored-by: Qiming Teng <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2025
@aojea @tengqm
Update content/en/docs/reference/command-line-tools-reference/feature…
7f5da64 
…-gates/MultiCIDRServiceAllocator.md

Co-authored-by: Qiming Teng <[email protected]>
aojea
aojea commented Mar 26, 2025
View reviewed changes
aojea
aojea commented Mar 26, 2025
View reviewed changes
@aojea
Copy link
Member Author

aojea commented Mar 27, 2025

@tengqm applied your suggestions

@rayandas
Copy link
Member

rayandas commented Apr 3, 2025

Hello @aojea 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT.
This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs.
The status of this enhancement is marked as At risk for docs freeze. Thank you!

@aojea
Copy link
Member Author

aojea commented Apr 3, 2025

Hello @aojea 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on 8th April, 2025 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as At risk for docs freeze. Thank you!

@tengqm the technical review is already approved, and you are comments are already addresssed

@tengqm tengqm added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 4, 2025
@tengqm
Copy link
Contributor

tengqm commented Apr 4, 2025

Upstream PR kubernetes/kubernetes#128971

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2025
@aojea
Copy link
Member Author

aojea commented Apr 4, 2025

the lgtm got dropped on the updates to the comments, can someone reapply it? there was no change on the technical content

@tengqm
Copy link
Contributor

tengqm commented Apr 5, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 5, 2025

LGTM label has been added.

Git tree hash: 286bfb70ebd469827376cfa3730af775a596fa96

@k8s-ci-robot k8s-ci-robot merged commit 4df1db9 into kubernetes:dev-1.33 Apr 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tengqm tengqm tengqm left review comments

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@shannonxtreme shannonxtreme Awaiting requested review from shannonxtreme

@danwinship danwinship Awaiting requested review from danwinship

@thockin thockin Awaiting requested review from thockin

Assignees

@danwinship danwinship

@tengqm tengqm

@thockin thockin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aojea @k8s-ci-robot @rayandas @tengqm @thockin @danwinship