Skip to content

Build draft content for local preview #48858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2024
Merged

Build draft content for local preview #48858

merged 1 commit into from
Dec 1, 2024

Conversation

@sftim
Copy link
Contributor

@sftim sftim commented Nov 26, 2024

Fix an issue where local previewing in a container didn't include draft content.

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 26, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 26, 2024
@sftim sftim mentioned this pull request Nov 26, 2024
Merged
@netlify
Copy link

netlify bot commented Nov 26, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 0372851
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67486946b70acb000833673a
😎 Deploy Preview https://deploy-preview-48858--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbianchidev
Copy link
Member

mbianchidev commented Nov 27, 2024

/lgtm

Great, I thought about it when I didn't see the draft content for the release blog.
The change make total sense!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 27, 2024

LGTM label has been added.

Git tree hash: 80269b89bca4c975bd8e56766234a058b15e97c5

dipesh-rawat
dipesh-rawat reviewed Nov 28, 2024
View reviewed changes
Makefile
$(CONTAINER_RUN) --cap-drop=ALL --cap-add=AUDIT_WRITE --read-only \
--mount type=tmpfs,destination=/tmp,tmpfs-mode=01777 -p 1313:1313 $(CONTAINER_IMAGE) \
hugo server --buildFuture --environment development --bind 0.0.0.0 --destination /tmp/public --cleanDestinationDir --noBuildLock
hugo server --buildDrafts --buildFuture --environment development --bind 0.0.0.0 --destination /tmp/public --cleanDestinationDir --noBuildLock
Copy link
Member

@dipesh-rawat dipesh-rawat Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good!

Would it be possible to apply a similar update to the serve Makefile target as well? It’s used for testing the site locally outside of the container, so it might help improve consistency with container preview method.

website/Makefile

Lines 58 to 59 in cee8816

serve: module-check ## Boot the development server.
hugo server --buildFuture --environment development

Copy link
Member

@mbianchidev mbianchidev Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe then also at line 99 to apply the change uniformly to every CMD

Copy link
Contributor Author

@sftim sftim Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See line 104 @mbianchidev

Build draft content for local preview
0372851 
Fix an issue where local previewing in server mode didn't include draft
content.
@sftim sftim force-pushed the 20241126_build_drafts_container_serve branch from c8d1b92 to 0372851 Compare November 28, 2024 12:59
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2024
@sftim
Copy link
Contributor Author

sftim commented Nov 28, 2024

/retitle Build draft content for local preview

@k8s-ci-robot k8s-ci-robot changed the title Build draft content for local container preview Build draft content for local preview Nov 28, 2024
@mbianchidev
Copy link
Member

mbianchidev commented Nov 28, 2024

/lgtm

It should be implemented for every relevant CMD now

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 28, 2024

LGTM label has been added.

Git tree hash: 9aaf36152156f57ef42ec1f56498ecf0336d2918

@katcosgrove
Copy link
Contributor

katcosgrove commented Dec 1, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: katcosgrove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7f599ff into kubernetes:main Dec 1, 2024
6 checks passed
@sftim sftim deleted the 20241126_build_drafts_container_serve branch March 22, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@reylejano reylejano Awaiting requested review from reylejano

@mbianchidev mbianchidev Awaiting requested review from mbianchidev

1 more reviewer

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mbianchidev mbianchidev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sftim @mbianchidev @k8s-ci-robot @katcosgrove @dipesh-rawat