Skip to content

Conversation

@pohly
Copy link
Contributor

@pohly pohly commented Oct 14, 2024

Description

DRA structured parameters are going to be beta in 1.32.

Issue

Related-to: kubernetes/enhancements#4381

@k8s-ci-robot k8s-ci-robot added this to the 1.32 milestone Oct 14, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 14, 2024
@pohly pohly changed the title DRA 1.32: beta WIP: DRA 1.32: beta Oct 14, 2024
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Oct 14, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 14, 2024
@netlify
Copy link

netlify bot commented Oct 14, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 26b5da0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67463ebea94d5200080ebd30

@netlify
Copy link

netlify bot commented Oct 14, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 26b5da0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67463ebea166170008016db5
😎 Deploy Preview https://deploy-preview-48330--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Nov 4, 2024

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Nov 4, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 19, 2024
@pohly pohly changed the title WIP: DRA 1.32: beta DRA 1.32: beta Nov 19, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2024
pohly added a commit to pohly/website that referenced this pull request Nov 19, 2024
As suggested in
kubernetes#48330 (comment), the
front matter gets extended to reference the API types. To make this work,
the necessary API reference files get created manually. They still need to be
updated via the usual automatic API generation.
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 19, 2024
pohly added a commit to pohly/website that referenced this pull request Nov 19, 2024
As suggested in
kubernetes#48330 (comment), the
front matter gets extended to reference the API types. To make this work,
the necessary API reference files get created manually. They still need to be
updated via the usual automatic API generation.
@pohly
Copy link
Contributor Author

pohly commented Nov 19, 2024

/wg device-management
/assign @johnbelamaric

@k8s-ci-robot k8s-ci-robot added the wg/device-management Categorizes an issue or PR as relevant to WG Device Management. label Nov 19, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@hacktivist123
Copy link
Contributor

Hello @pohly 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday November 26th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. Thank you!

@pohly
Copy link
Contributor Author

pohly commented Nov 26, 2024

/assign @klueska @SergeyKanzhelev

Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bedb07fc232dc320be3d733d172460c99b140739

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2024
@salaxander
Copy link
Contributor

/lgtm from SIG Docs pending rebase

@reylejano
Copy link
Member

Thank you for addressing all the comments and reviews
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2024
As part of promoting the core DRA to beta, the admin access feature gate was
added to keep that aspect as alpha.
As suggested in
kubernetes#48330 (comment), the
front matter gets extended to reference the API types. To make this work,
the necessary API reference files get created manually. They still need to be
updated via the usual automatic API generation.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2024
@pohly
Copy link
Contributor Author

pohly commented Nov 26, 2024

@salaxander (or anyone): rebased, please re-apply LGTM.

@salaxander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 04c0cff6aef9745143fccb66208d18236fba5945

@k8s-ci-robot k8s-ci-robot merged commit 2131b01 into kubernetes:dev-1.32 Nov 26, 2024
5 of 6 checks passed
Andygol pushed a commit to Andygol/k8s-website that referenced this pull request Dec 31, 2024
As suggested in
kubernetes#48330 (comment), the
front matter gets extended to reference the API types. To make this work,
the necessary API reference files get created manually. They still need to be
updated via the usual automatic API generation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.