Skip to content

blog post for MatchLabelKeys in PodAffinity #46833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 14, 2024
Merged

blog post for MatchLabelKeys in PodAffinity #46833

merged 4 commits into from
Aug 14, 2024

Conversation

@sanposhiho
Copy link
Member

@sanposhiho sanposhiho commented Jun 15, 2024 •
edited by sftim
Loading

This is just a place holder PR for now.

It's a blog post for kubernetes/enhancements#3633

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 15, 2024
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Jun 15, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim June 15, 2024 15:14
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels Jun 15, 2024
@sanposhiho sanposhiho mentioned this pull request Jun 15, 2024
Closed
12 tasks
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 15, 2024
@netlify
Copy link

netlify bot commented Jun 15, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 43f612f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66a4c9a21360b50008ba7d85
😎 Deploy Preview https://deploy-preview-46833--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sanposhiho sanposhiho marked this pull request as draft June 15, 2024 15:34
@sftim
Copy link
Contributor

sftim commented Jun 23, 2024

/hold

pending assignment of publication date (by release comms)

we'll also keep this held until the v1.31 release has happened

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2024
@mbianchidev
Copy link
Member

mbianchidev commented Jul 15, 2024

Hey @sanposhiho , it's Matteo from the 1.31 Release comms team.
I'm reaching out with a reminder that the blog ready for review deadline is July 26, 2024.

Please let me know how we can help with content, review or anything else 😄

@sanposhiho sanposhiho force-pushed the blog-matchlabelkeys-podaffinity branch from 840b7ca to 024c13b Compare July 20, 2024 15:25
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 20, 2024
@sanposhiho sanposhiho changed the title wip: blog post for MatchLabelKeys in PodAffinity blog post for MatchLabelKeys in PodAffinity Jul 20, 2024
@sanposhiho sanposhiho marked this pull request as ready for review July 20, 2024 15:26
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2024
@k8s-ci-robot k8s-ci-robot requested a review from Gauravpadam July 20, 2024 15:27
@sanposhiho
Copy link
Member Author

sanposhiho commented Jul 20, 2024

Now it's ready for review.

@mbianchidev
Copy link
Member

mbianchidev commented Jul 24, 2024

Blog publish date is currently scheduled for August 16, 2024 @sanposhiho
I'll take a look this or next week for a review :)

mbianchidev
mbianchidev reviewed Jul 24, 2024
View reviewed changes
Copy link
Member

@mbianchidev mbianchidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content from is ok overall but it will probably need approval from a more technical perspective and we may need someone from the sig to step in and review that more in depth.

@sanposhiho
Copy link
Member Author

sanposhiho commented Jul 25, 2024

@Huang-Wei can you also possibly take a look from KEP reviewer pov?

Huang-Wei
Huang-Wei reviewed Jul 25, 2024
View reviewed changes
mbianchidev
mbianchidev approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@mbianchidev mbianchidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My review is done and this is a content-wise approve!
+1 from me

@tengqm tengqm added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 27, 2024
@tengqm
Copy link
Contributor

tengqm commented Jul 27, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mbianchidev, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2024
@tengqm
Copy link
Contributor

tengqm commented Jul 27, 2024

@sanposhiho You may want to change "rolling upgrade" to "rolling update" if possible. Updating a Deployment doesn't always translate to "upgrade"; it could be a "downgrade" in some cases.

@sanposhiho
Copy link
Member Author

sanposhiho commented Jul 27, 2024

Good point, fixed.

@T-Lakshmi
Copy link
Contributor

T-Lakshmi commented Jul 29, 2024

Preview page

@mbianchidev
Copy link
Member

mbianchidev commented Aug 7, 2024

@natalisucks this one is approved and requires a lgtm label 👀

@natalisucks
Copy link
Contributor

natalisucks commented Aug 12, 2024

/hold
/lgtm

Copying @sftim's warning note, thanks Tim!

🛑 Do not unhold or merge before Kubernetes v1.31 is released 🛑

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 12, 2024

LGTM label has been added.

Git tree hash: 3a0583c72c269ef2c09c640b33f9fe0412385ee5

@a-mccarthy
Copy link
Contributor

a-mccarthy commented Aug 14, 2024

/unhold

Kubernetes v1.31 has been released.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit c6eebed into kubernetes:main Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

@sftim sftim Awaiting requested review from sftim

@Gauravpadam Gauravpadam Awaiting requested review from Gauravpadam

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

1 more reviewer

@mbianchidev mbianchidev mbianchidev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@natalisucks natalisucks

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@sanposhiho @sftim @mbianchidev @tengqm @k8s-ci-robot @T-Lakshmi @natalisucks @a-mccarthy @Huang-Wei